Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: palantir/blueprint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @blueprintjs/select@5.3.14
Choose a base ref
...
head repository: palantir/blueprint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @blueprintjs/select@5.3.15
Choose a head ref
  • 6 commits
  • 19 files changed
  • 2 contributors

Commits on Feb 28, 2025

  1. fix(InputGroup, NumericInput): Add back compat for size prop

    jscheiny committed Feb 28, 2025
    1
    Copy the full SHA
    9f1c089 View commit details
  2. Revert "fix(InputGroup, NumericInput): Add back compat for size prop"

    This reverts commit 9f1c089.
    jscheiny committed Feb 28, 2025
    1

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    d771cd8 View commit details

Commits on Mar 3, 2025

  1. fix(InputGroup, NumericInput): Add back compat for size prop (#7288)

    jscheiny authored Mar 3, 2025
    1
    Copy the full SHA
    22e8c58 View commit details
  2. Add script to pack/store packages on develop and next (#7287)

    ggdouglas authored Mar 3, 2025
    1
    Copy the full SHA
    fa55ed5 View commit details
  3. [DialogBody] Set missing useOverflowScrollContainer default prop (#…

    ggdouglas authored Mar 3, 2025
    1
    Copy the full SHA
    08f3e87 View commit details
  4. chore: Publish new release

     - @blueprintjs/core@5.17.3
     - @blueprintjs/datetime@5.3.27
     - @blueprintjs/datetime2@2.3.27
     - @blueprintjs/demo-app@5.16.10
     - @blueprintjs/docs-app@5.16.10
     - @blueprintjs/docs-data@5.16.10
     - @blueprintjs/docs-theme@5.3.27
     - @blueprintjs/karma-build-scripts@5.2.18
     - @blueprintjs/landing-app@5.16.10
     - @blueprintjs/popover2@2.1.26
     - @blueprintjs/select@5.3.15
     - @blueprintjs/table-dev-app@5.2.17
     - @blueprintjs/table@5.3.9
    jscheiny committed Mar 3, 2025
    2
    Copy the full SHA
    f6b734f View commit details
13 changes: 13 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -203,6 +203,17 @@ jobs:
- store_artifacts: { path: packages/demo-app/dist }
- run: ./scripts/submit-preview-comment.sh

store-packages:
docker: *docker-node-image
steps:
- checkout
- restore_cache: *restore-node-modules-cache
- attach_workspace: { at: "." }
- run: sudo corepack enable
- run: mkdir ./artifacts
- run: ./scripts/pack-npm
- store_artifacts: { path: ./artifacts }

deploy-npm:
docker: *docker-node-image
steps:
@@ -234,6 +245,8 @@ workflows:
requires: [compile]
- deploy-preview:
requires: [dist]
- store-packages:
requires: [dist]
- deploy-npm:
requires: [dist, lint, test-node-libs, test-react-18, test-iso-react-18]
filters:
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/core",
"version": "5.17.2",
"version": "5.17.3",
"description": "Core styles & components",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
3 changes: 2 additions & 1 deletion packages/core/src/common/classes.ts
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@ import type { ButtonVariant } from "./buttonVariant";
import { Elevation } from "./elevation";
import { Intent } from "./intent";
import { Position } from "./position";
import type { HTMLInputProps } from "./props";
import type { Size } from "./size";

// injected by webpack.DefinePlugin
@@ -448,7 +449,7 @@ export function positionClass(position: Position | undefined) {
}

export function sizeClass(
size: Size,
size: Size | HTMLInputProps["size"],
legacyProps: Partial<Record<"large" | "small", boolean>>,
): string | Record<string, boolean> {
if (size === "small") {
2 changes: 1 addition & 1 deletion packages/core/src/components/dialog/dialogBody.tsx
Original file line number Diff line number Diff line change
@@ -38,7 +38,7 @@ export interface DialogBodyProps extends Props, HTMLDivProps {
* @see https://blueprintjs.com/docs/#core/components/dialog.dialog-body-props
*/
export const DialogBody: React.FC<DialogBodyProps> = props => {
const { children, className, useOverflowScrollContainer, ...htmlProps } = props;
const { children, className, useOverflowScrollContainer = true, ...htmlProps } = props;
return (
<div
{...htmlProps}
8 changes: 5 additions & 3 deletions packages/core/src/components/forms/inputGroup.tsx
Original file line number Diff line number Diff line change
@@ -63,11 +63,13 @@ export interface InputGroupProps
small?: boolean;

/**
* Size of the input.
* Size of the input. If given a numeric value, and `inputSize` is not defined, then this will be provided as the
* `size` attribute for the underyling native HTML input element. Passing a numeric value this way is deprecated,
* use the `inputSize` prop instead.
*
* @default "medium"
*/
size?: Size;
size?: Size | HTMLInputProps["size"];

/**
* Alias for the native HTML input `size` attribute.
@@ -161,7 +163,7 @@ export class InputGroup extends AbstractPureComponent<InputGroupProps, InputGrou
"aria-disabled": disabled,
className: classNames(Classes.INPUT, inputClassName),
onChange: this.handleInputChange,
size: inputSize,
size: inputSize ?? (typeof size === "number" ? size : undefined),
style,
} satisfies React.HTMLProps<HTMLInputElement>;
const inputElement = asyncControl ? (
6 changes: 4 additions & 2 deletions packages/core/src/components/forms/numericInput.tsx
Original file line number Diff line number Diff line change
@@ -155,11 +155,13 @@ export interface NumericInputProps extends InputSharedProps {
small?: boolean;

/**
* The size of the input.
* Size of the input. If given a numeric value, and `inputSize` is not defined, then this will be provided as the
* `size` attribute for the underyling native HTML input element. Passing a numeric value this way is deprecated,
* use the `inputSize` prop instead.
*
* @default "medium"
*/
size?: Size;
size?: Size | HTMLInputProps["size"];

/**
* Alias for the native HTML input `size` attribute.
2 changes: 1 addition & 1 deletion packages/datetime/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/datetime",
"version": "5.3.26",
"version": "5.3.27",
"description": "Components for interacting with dates and times",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
2 changes: 1 addition & 1 deletion packages/datetime2/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/datetime2",
"version": "2.3.26",
"version": "2.3.27",
"description": "Re-exports of @blueprintjs/datetime APIs",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
2 changes: 1 addition & 1 deletion packages/demo-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/demo-app",
"version": "5.16.9",
"version": "5.16.10",
"description": "Blueprint Demo App",
"private": true,
"scripts": {
2 changes: 1 addition & 1 deletion packages/docs-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/docs-app",
"version": "5.16.9",
"version": "5.16.10",
"description": "Blueprint Documentation Site",
"private": true,
"scripts": {
2 changes: 1 addition & 1 deletion packages/docs-data/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/docs-data",
"version": "5.16.9",
"version": "5.16.10",
"main": "src/index.js",
"types": "src/index.d.ts",
"private": true,
2 changes: 1 addition & 1 deletion packages/docs-theme/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/docs-theme",
"version": "5.3.26",
"version": "5.3.27",
"description": "Blueprint theme for documentalist",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
2 changes: 1 addition & 1 deletion packages/karma-build-scripts/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/karma-build-scripts",
"version": "5.2.17",
"version": "5.2.18",
"description": "Karma build scripts for @blueprintjs packages",
"type": "module",
"main": "index.mjs",
2 changes: 1 addition & 1 deletion packages/landing-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/landing-app",
"version": "5.16.9",
"version": "5.16.10",
"description": "Blueprint landing page",
"private": true,
"scripts": {
2 changes: 1 addition & 1 deletion packages/popover2/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/popover2",
"version": "2.1.25",
"version": "2.1.26",
"description": "Re-exports of popover-related components from @blueprintjs/core",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
2 changes: 1 addition & 1 deletion packages/select/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/select",
"version": "5.3.14",
"version": "5.3.15",
"description": "Components related to selecting items from a list",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
2 changes: 1 addition & 1 deletion packages/table-dev-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/table-dev-app",
"version": "5.2.16",
"version": "5.2.17",
"description": "Dev application for @blueprintjs/table",
"private": true,
"scripts": {
2 changes: 1 addition & 1 deletion packages/table/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@blueprintjs/table",
"version": "5.3.8",
"version": "5.3.9",
"description": "Scalable interactive table component",
"main": "lib/cjs/index.js",
"module": "lib/esm/index.js",
21 changes: 21 additions & 0 deletions scripts/pack-npm
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#!/bin/bash

set -e
set -o pipefail

packages=("colors" "core" "datetime" "datetime2" "icons" "select" "table")

mkdir -p artifacts

for package in ${packages[@]}; do
path="packages/$package"
pushd $path

version=$(jq -r '.version' package.json)
filename="../../artifacts/blueprintjs-$(basename "$path")-$version.tgz"

echo "Attempting to pack package at path '$path'"
yarn pack --filename $filename

popd
done