Fix issues handling golang packages with multi-part namespaces. #20
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test for it as well.
brbayes-msft
previously approved these changes
Dec 7, 2022
pmalmsten
previously approved these changes
Dec 8, 2022
am11
previously approved these changes
Dec 8, 2022
am11
reviewed
Dec 8, 2022
Match packageurl-js implementation for namespace encoding. Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
jpinz
dismissed stale reviews from am11, pmalmsten, and brbayes-msft
via
569fb16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go package
pkg:golang/github.com/gorilla/context@234fd47e07d1004f0aed9c#apiwould previously bepkg:golang/github.com%2Cgorilla/context@234fd47e07d1004f0aed9c#apias the namespace would be split and joined with,vs/.Added a test for it as well.
For context, the packageurl-js implementation handles namespaces in this new way.