Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript config example to README #197

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

aarongoldenthal
Copy link
Contributor

Update README to include additional details and example with JavaScript config file, including how it can be used to dynamically update config. Based on question from #193.

@aarongoldenthal
Copy link
Contributor Author

aarongoldenthal commented Dec 3, 2022

The GitHub actions failures seem to be caused by ubuntu-latest moving to v22.04, per pa11y/pa11y#651 and pa11y/pa11y#662 (they tests all pass if pinning to ubuntu-20.04, although that's obviously not a long-term fix).

@danyalaytekin
Copy link
Member

danyalaytekin commented Nov 14, 2023

@aarongoldenthal Hello again! Thanks for this contribution too. As I mentioned I'd like to merge it into main before we publish v3.1.0. I've made two commits with tweaks which are described by their commit names above - please let me know whether you think they're ok or would like me to revert them, or for us to make further changes.

P.S. About your pinning comment - as you've probably noticed, I have settled for the pinning for now, for these minor-level updates, although I'm working to describe the chromeLaunchConfig workaround consistently across repos. Normal *-latest service will return with the next major version of each project.

@aarongoldenthal
Copy link
Contributor Author

@aarongoldenthal Hello again! Thanks for this contribution too. As I mentioned I'd like to merge it into main before we publish v3.1.0. I've made two commits with tweaks which are described by their commit names above - please let me know whether you think they're ok or would like me to revert them, or for us to make further changes.

@danyalaytekin LGTM

@danyalaytekin danyalaytekin merged commit 4ab436d into pa11y:main Nov 14, 2023
16 checks passed
danyalaytekin added a commit that referenced this pull request Nov 14, 2023
danyalaytekin added a commit that referenced this pull request Nov 14, 2023
* Change id of publishing job to `publish` from `build`

* Set version to `3.1.0` from `3.0.1`

* Add changelog entry for `3.1.0`

* Shorten link to full changelog

* Remove errant `npx`

* Fix syntax for notes

* Add #197 to changelog

* Fix Node version’s badge
stevenleija added a commit to stevenleija/pa11y-ci-stevenleija that referenced this pull request May 2, 2024
* origin/master:
  Bump ip from 1.1.8 to 1.1.9
  Update to Pa11y v7 and other dependency updates (pa11y#231)
  Version `3.1.0` (pa11y#226)
  Add JavaScript config example to README (pa11y#197)
  Bump @babel/traverse from 7.16.0 to 7.23.3 (pa11y#222)
  Bump semver from 6.3.0 to 6.3.1 (pa11y#221)
  Bump json5 from 2.2.0 to 2.2.3 (pa11y#219)
  Bump ansi-regex from 3.0.0 to 3.0.1 (pa11y#218)
  Bump debug from 4.1.1 to 4.3.1 (pa11y#216)
  Bump node-fetch from 2.6.1 to 2.6.7 (pa11y#217)
  Upgrade to `pa11y@6.2.3`, add publishing workflow (pa11y#213)
  Update integration tests to support all platforms, including Windows (pa11y#177)

# Conflicts:
#	bin/pa11y-ci.js
#	package-lock.json
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants