Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GitHub Actions to checking out the PR tip by default #4461

Closed
sunshowers opened this issue Nov 8, 2023 · 0 comments · Fixed by #4462
Closed

Switch GitHub Actions to checking out the PR tip by default #4461

sunshowers opened this issue Nov 8, 2023 · 0 comments · Fixed by #4462

Comments

@sunshowers
Copy link
Contributor

sunshowers commented Nov 8, 2023

On running a pull_request action, GitHub Actions, in a decision which appears to be somewhat surprising at first, does not check out the pull request tip. Instead, it checks out a merge commit of the PR tip with the target branch as of the time the PR was created. See actions/checkout#426 for more discussion.

Buildomat currently always uses the PR tip.

While there are reasonable arguments and trade-offs in both directions, the most important thing is to make sure that Buildomat and GitHub Actions use the same scheme. The most straightforward way to do that is to switch GHA to using the PR tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant