Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(codegen): restrict visibility of internal methods #6145

Conversation

DonIsaac
Copy link
Contributor

add pub(crate) to Codegen methods that should only be used within oxc_codegen

Copy link

graphite-app bot commented Sep 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 28, 2024 — with Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-codegen Area - Code Generation label Sep 28, 2024
@DonIsaac DonIsaac marked this pull request as ready for review September 28, 2024 14:24
Copy link

codspeed-hq bot commented Sep 28, 2024

CodSpeed Performance Report

Merging #6145 will not alter performance

Comparing don/09-28-refactor_codegen_restrict_visibility_of_internal_methods (ab187d1) with main (be0030c)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 28, 2024
Copy link

graphite-app bot commented Sep 28, 2024

Merge activity

  • Sep 28, 10:33 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 28, 10:33 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 28, 10:37 AM EDT: Boshen merged this pull request with the Graphite merge queue.

add `pub(crate)` to `Codegen` methods that should only be used within `oxc_codegen`
@Boshen Boshen force-pushed the don/09-28-refactor_codegen_restrict_visibility_of_internal_methods branch from 5ac458b to ab187d1 Compare September 28, 2024 14:33
@graphite-app graphite-app bot merged commit ab187d1 into main Sep 28, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/09-28-refactor_codegen_restrict_visibility_of_internal_methods branch September 28, 2024 14:37
Boshen added a commit that referenced this pull request Sep 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
## [0.30.5] - 2024-09-29

### Features

- 15552ac napi/transform: Display semantic error (#6160) (Boshen)
- f50fdcd napi/transform: Make react refresh option take a boolean
(#6146) (Boshen)

### Bug Fixes

- f27d59f napi/transform: Remove confusing `jsx` option (#6159) (Boshen)
- bfd1988 transformer/react: Should not collect use-hooks if it's a
nested member expression (#6143) (Dunqing)

### Refactor

- ab187d1 codegen: Restrict visibility of internal methods (#6145)
(DonIsaac)
- 375bebe transformer: Improve parsing React pragmas (#6138)
(overlookmotel)
- 0836f6b transformer: Move parsing pragmas into TS transform (#6137)
(overlookmotel)
- 30424fa transformer: TS transforms only store options they need
(#6135) (overlookmotel)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants