Skip to content

Commit e929f26

Browse files
committedJan 31, 2025·
fix(linter): output LintCommandInfo for CliRunResult::LintNoFilesFound (#8714)
In the older version we outputted the found warnings and errors (which also be zero). This is only reimplementing a part of the old behavior ands skips the old output here: https://github.com/oxc-project/oxc/blob/4a2f2a9cd996cacf85b9e14467397d34497f6e96/apps/oxlint/src/output_formatter/default.rs#L84-L110 Bug found here: https://github.com/oxc-project/oxc/blob/659c225c5683363c8bd5ac78444ce7ce349b43e3/apps/oxlint/src/snapshots/_--ignore-path%20fixtures__linter__.customignore%20fixtures__linter__nan.js%40oxlint.snap
1 parent 18f1b15 commit e929f26

4 files changed

+13
-0
lines changed
 

Diff for: ‎apps/oxlint/src/lint.rs

+10
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,16 @@ impl Runner for LintRunner {
147147
// If explicit paths were provided, but all have been
148148
// filtered, return early.
149149
if provided_path_count > 0 {
150+
if let Some(end) = output_formatter.lint_command_info(&LintCommandInfo {
151+
number_of_files: 0,
152+
number_of_rules: 0,
153+
threads_count: rayon::current_num_threads(),
154+
start_time: now.elapsed(),
155+
}) {
156+
stdout.write_all(end.as_bytes()).or_else(Self::check_for_writer_error).unwrap();
157+
stdout.flush().unwrap();
158+
};
159+
150160
return CliRunResult::LintNoFilesFound;
151161
}
152162

Diff for: ‎apps/oxlint/src/snapshots/_--ignore-path fixtures__issue_7566__.oxlintignore fixtures__issue_7566__tests__main.js fixtures__issue_7566__tests__function__main.js@oxlint.snap

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ source: apps/oxlint/src/tester.rs
55
arguments: --ignore-path fixtures/issue_7566/.oxlintignore fixtures/issue_7566/tests/main.js fixtures/issue_7566/tests/function/main.js
66
working directory:
77
----------
8+
Finished in <variable>ms on 0 files with 0 rules using 1 threads.
89
----------
910
CLI result: LintNoFilesFound
1011
----------

Diff for: ‎apps/oxlint/src/snapshots/_--ignore-path fixtures__linter__.customignore fixtures__linter__nan.js@oxlint.snap

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ source: apps/oxlint/src/tester.rs
55
arguments: --ignore-path fixtures/linter/.customignore fixtures/linter/nan.js
66
working directory:
77
----------
8+
Finished in <variable>ms on 0 files with 0 rules using 1 threads.
89
----------
910
CLI result: LintNoFilesFound
1011
----------

Diff for: ‎apps/oxlint/src/snapshots/_-c fixtures__config_ignore_patterns__ignore_extension__eslintrc.json fixtures__config_ignore_patterns__ignore_extension__main.js@oxlint.snap

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ source: apps/oxlint/src/tester.rs
55
arguments: -c fixtures/config_ignore_patterns/ignore_extension/eslintrc.json fixtures/config_ignore_patterns/ignore_extension/main.js
66
working directory:
77
----------
8+
Finished in <variable>ms on 0 files with 0 rules using 1 threads.
89
----------
910
CLI result: LintNoFilesFound
1011
----------

0 commit comments

Comments
 (0)
Please sign in to comment.