fix(linter): global variables should always check the builtin variables (#4209)

jelly · web-flow · commit dd07a5475b7d · 2024-07-11T13:22:34.000-04:00
This fixes commit dbbb6fc. Closes #3374
diff --git a/crates/oxc_linter/src/context.rs b/crates/oxc_linter/src/context.rs
@@ -137,7 +137,7 @@ impl<'a> LintContext<'a> {
     }
 
     pub fn env_contains_var(&self, var: &str) -> bool {
-        if GLOBALS["builtin"].contains_key("var") {
+        if GLOBALS["builtin"].contains_key(var) {
             return true;
         }
         for env in self.env().iter() {

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ impl<'a> LintContext<'a> {`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`pub fn env_contains_var(&self, var: &str) -> bool {`
`140`		`- if GLOBALS["builtin"].contains_key("var") {`
	`140`	`+ if GLOBALS["builtin"].contains_key(var) {`
`141`	`141`	`return true;`
`142`	`142`	`}`
`143`	`143`	`for env in self.env().iter() {`