fix(parser): error when } and > appear in JSXText (#9777)

closes #9770

Author: Boshen

crates/oxc_codegen/src/gen.rs

@@ -2578,8 +2578,9 @@ impl Gen for JSXText<'_> {
 
 impl Gen for JSXSpreadChild<'_> {
     fn r#gen(&self, p: &mut Codegen, _ctx: Context) {
-        p.print_str("...");
+        p.print_str("{...");
         p.print_expression(&self.expression);
+        p.print_ascii_byte(b'}');
     }
 }
 
@@ -2588,7 +2589,7 @@ impl Gen for JSXChild<'_> {
         match self {
             Self::Fragment(fragment) => fragment.print(p, ctx),
             Self::Element(el) => el.print(p, ctx),
-            Self::Spread(spread) => p.print_expression(&spread.expression),
+            Self::Spread(spread) => spread.print(p, ctx),
             Self::ExpressionContainer(expr_container) => expr_container.print(p, ctx),
             Self::Text(text) => text.print(p, ctx),
         }

crates/oxc_linter/src/rules/eslint/no_unused_expressions.rs

@@ -292,7 +292,7 @@ fn test() {
             "
 			      namespace Foo {
 			        'use strict';
-			
+
 			        export class Foo {}
 			        export class Bar {}
 			      }
@@ -303,7 +303,7 @@ fn test() {
             "
 			      function foo() {
 			        'use strict';
-			
+
 			        return null;
 			      }
 			    ",
@@ -383,7 +383,7 @@ fn test() {
         ("<></>", Some(serde_json::json!([{ "enforceForJSX": true }]))), // { "parserOptions": { "ecmaFeatures": { "jsx": true } } },
         ("class C { static { 'use strict'; } }", None),                  // { "ecmaVersion": 2022 },
         (
-            "class C { static { 
+            "class C { static {
 			'foo'
 			'bar'
 			 } }",
@@ -479,7 +479,7 @@ fn test() {
 			namespace Foo {
 			  export class Foo {}
 			  export class Bar {}
-			
+
 			  'use strict';
 			}
 			      ",
@@ -489,7 +489,7 @@ fn test() {
             "
 			function foo() {
 			  const foo = true;
-			
+
 			  'use strict';
 			}
 			      ",
@@ -519,13 +519,13 @@ fn test() {
 			      ",
             None,
         ),
-        (
-            "
-			declare const foo: number | undefined;
-			<any>foo;
-			      ",
-            None,
-        ),
+        // (
+        // "
+        // declare const foo: number | undefined;
+        // <any>foo;
+        // ",
+        // None,
+        // ),
         (
             "
 			declare const foo: number | undefined;

crates/oxc_linter/src/rules/react/no_unescaped_entities.rs

@@ -76,13 +76,11 @@ impl Rule for NoUnescapedEntities {
 }
 
 // NOTE: If we add substantially more characters, we should consider using a hash set instead.
-pub const CHARS: [char; 4] = ['>', '"', '\'', '}'];
+pub const CHARS: [char; 2] = ['"', '\''];
 
 pub const DEFAULTS: Map<char, &'static [&'static str]> = phf_map! {
-    '>' => &["&gt;"],
     '"' => &["&quot;", "&ldquo;", "&#34;", "&rdquo;"],
     '\'' => &["&apos;", "&lsquo;", "&#39;", "&rsquo;"],
-    '}' => &["&#125;"],
 };
 
 #[test]

crates/oxc_linter/src/rules/typescript/array_type.rs

@@ -1011,10 +1011,10 @@ fn test() {
             "let x: Array<undefined> = [undefined] as undefined[];",
             Some(serde_json::json!([{"default":"array-simple"}])),
         ),
-        (
-            "let y: string[] = <Array<string>>['2'];",
-            Some(serde_json::json!([{"default":"array-simple"}])),
-        ),
+        // (
+        // "let y: string[] = <Array<string>>['2'];",
+        // Some(serde_json::json!([{"default":"array-simple"}])),
+        // ),
         ("let z: Array = [3, '4'];", Some(serde_json::json!([{"default":"array-simple"}]))),
         (
             "let ya = [[1, '2']] as [number, string][];",
@@ -1062,7 +1062,7 @@ fn test() {
             "let x: Array<undefined> = [undefined] as undefined[];",
             Some(serde_json::json!([{"default":"array"}])),
         ),
-        ("let y: string[] = <Array<string>>['2'];", Some(serde_json::json!([{"default":"array"}]))),
+        // ("let y: string[] = <Array<string>>['2'];", Some(serde_json::json!([{"default":"array"}]))),
         ("let z: Array = [3, '4'];", Some(serde_json::json!([{"default":"array"}]))),
         ("type Arr<T> = Array<T>;", Some(serde_json::json!([{"default":"array"}]))),
         // ("
@@ -1706,5 +1706,8 @@ fn test() {
         ),
     ];
 
-    Tester::new(ArrayType::NAME, ArrayType::PLUGIN, pass, fail).expect_fix(fix).test_and_snapshot();
+    Tester::new(ArrayType::NAME, ArrayType::PLUGIN, pass, fail)
+        .change_rule_path_extension("ts")
+        .expect_fix(fix)
+        .test_and_snapshot();
 }

crates/oxc_linter/src/snapshots/eslint_no_unused_expressions.snap

@@ -241,7 +241,7 @@ source: crates/oxc_linter/src/tester.rs
 
   ⚠ eslint(no-unused-expressions): Disallow unused expressions
    ╭─[no_unused_expressions.tsx:2:4]
- 1 │ class C { static { 
+ 1 │ class C { static {
  2 │             'foo'
    ·             ─────
  3 │             'bar'
@@ -378,7 +378,7 @@ source: crates/oxc_linter/src/tester.rs
 
   ⚠ eslint(no-unused-expressions): Disallow unused expressions
    ╭─[no_unused_expressions.tsx:6:6]
- 5 │             
+ 5 │ 
  6 │               'use strict';
    ·               ─────────────
  7 │             }
@@ -387,7 +387,7 @@ source: crates/oxc_linter/src/tester.rs
 
   ⚠ eslint(no-unused-expressions): Disallow unused expressions
    ╭─[no_unused_expressions.tsx:5:6]
- 4 │             
+ 4 │ 
  5 │               'use strict';
    ·               ─────────────
  6 │             }
@@ -442,12 +442,6 @@ source: crates/oxc_linter/src/tester.rs
    ╰────
   help: Consider removing this expression
 
-  × Expected `<` but found `EOF`
-   ╭─[no_unused_expressions.tsx:4:10]
- 3 │             <any>foo;
- 4 │                   
-   ╰────
-
   ⚠ eslint(no-unused-expressions): Disallow unused expressions
    ╭─[no_unused_expressions.tsx:3:4]
  2 │             declare const foo: number | undefined;

crates/oxc_linter/src/snapshots/react_no_unescaped_entities.snap

@@ -1,19 +1,19 @@
 ---
 source: crates/oxc_linter/src/tester.rs
 ---
-  ⚠ eslint-plugin-react(no-unescaped-entities): `>` can be escaped with >
+  × Unexpected token. Did you mean `{'>'}` or `>`?
    ╭─[no_unescaped_entities.tsx:3:24]
  2 │             render: function() {
  3 │               return <>> babel-eslint</>;
-   ·                        ─
+   ·                        ▲
  4 │             }
    ╰────
 
-  ⚠ eslint-plugin-react(no-unescaped-entities): `>` can be escaped with &gt;
+  × Unexpected token. Did you mean `{'>'}` or `&gt;`?
    ╭─[no_unescaped_entities.tsx:5:47]
  4 │               so is second
  5 │               and here are some bad entities: ></>
-   ·                                               ─
+   ·                                               ▲
  6 │             }
    ╰────
 
@@ -25,11 +25,11 @@ source: crates/oxc_linter/src/tester.rs
  5 │             }
    ╰────
 
-  ⚠ eslint-plugin-react(no-unescaped-entities): `}` can be escaped with &#125;
+  × Unexpected token. Did you mean `{'}'}` or `&rbrace;`?
    ╭─[no_unescaped_entities.tsx:4:60]
  3 │             render: function() {
  4 │               return <>{"Unbalanced braces - babel-eslint"}}</>;
-   ·                                                            ─
+   ·                                                            ▲
  5 │             }
    ╰────