docs(linter): Improve eslint-no-async-promise-executor (#9778)

Adds correctness examples and format in line with #6050

Author: therewillbecode

crates/oxc_linter/src/rules/eslint/no_async_promise_executor.rs

@@ -17,14 +17,14 @@ pub struct NoAsyncPromiseExecutor;
 
 declare_oxc_lint!(
     /// ### What it does
-    /// Disallow using an async function as a Promise executor
+    ///
+    /// Disallow using an async function as a Promise executor.
     ///
     /// ### Why is this bad?
-    /// The `new Promise` constructor accepts an executor function as an argument,
-    /// which has `resolve` and `reject` parameters that can be used to control the state of the created Promise.
-    /// For example:
     ///
-    /// ### Example
+    /// The `new Promise` constructor accepts an executor function as an argument,
+    /// which has `resolve` and `reject` parameters that can be used to control the state of the
+    /// created Promise. For example:
     /// ```javascript
     /// const result = new Promise(function executor(resolve, reject) {
     ///   readFile('foo.txt', function(err, result) {
@@ -36,11 +36,46 @@ declare_oxc_lint!(
     ///   });
     /// });
     /// ```
-    ///
     /// The executor function can also be an `async function`. However, this is usually a mistake, for a few reasons:
+    /// - If an async executor function throws an error, the error will be lost and won’t cause
+    ///   the newly-constructed `Promise` to reject.This could make it difficult to debug and handle some errors.
+    /// - If a `Promise` executor function is using `await`, this is usually a sign that it is not
+    ///   actually necessary to use the new `Promise` constructor, or the scope of the new
+    ///   `Promise` constructor can be reduced.
+    ///
+    /// ### Examples
+    ///
+    /// Examples of **incorrect** code for this rule:
+    /// ```javascript
+    /// const foo = new Promise(async (resolve, reject) => {
+    ///   readFile('foo.txt', function(err, result) {
+    ///     if (err) {
+    ///       reject(err);
+    ///     } else {
+    ///       resolve(result);
+    ///     }
+    ///   });
+    /// });
     ///
-    /// - If an async executor function throws an error, the error will be lost and won’t cause the newly-constructed `Promise` to reject.This could make it difficult to debug and handle some errors.
-    /// - If a Promise executor function is using `await`, this is usually a sign that it is not actually necessary to use the `new Promise` constructor, or the scope of the `new Promise` constructor can be reduced.
+    /// const result = new Promise(async (resolve, reject) => {
+    ///   resolve(await foo);
+    /// });
+    /// ```
+    ///
+    /// Examples of **correct** code for this rule:
+    /// ```javascript
+    /// const foo = new Promise((resolve, reject) => {
+    ///   readFile('foo.txt', function(err, result) {
+    ///     if (err) {
+    ///       reject(err);
+    ///     } else {
+    ///       resolve(result);
+    ///     }
+    ///   });
+    /// });
+    ///
+    /// const result = Promise.resolve(foo);
+    /// ```
     NoAsyncPromiseExecutor,
     eslint,
     correctness