perf(linter): replace phf_set with array in globals (#10274)

Related to #10076

Author: shulaoda

crates/oxc_linter/src/globals.rs

@@ -1,11 +1,16 @@
 use phf::phf_set;
 
-pub const GLOBAL_OBJECT_NAMES: phf::Set<&'static str> = phf_set! {
-    "global",
-    "globalThis",
-    "self",
-    "window",
-};
+pub const GLOBAL_OBJECT_NAMES: [&str; 4] = ["global", "globalThis", "self", "window"];
+
+/// set of reserved HTML tag names definition
+/// if it's not reserved, then it can have aria-* roles, states, and properties
+/// Reference: <https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules#ax_aria_12>
+/// Reference: <https://www.w3.org/TR/html-aria/#rules-wd>
+/// Reference: <https://github.com/A11yance/aria-query/blob/v5.3.2/src/domMap.js>
+pub const RESERVED_HTML_TAG: [&str; 16] = [
+    "base", "col", "colgroup", "head", "html", "link", "meta", "noembed", "noscript", "param",
+    "picture", "script", "source", "style", "title", "track",
+];
 
 /// set of valid ARIA properties from the WAI-ARIA 1.1 specifications.
 /// Reference: <https://www.w3.org/TR/wai-aria/#state_prop_def>
@@ -342,27 +347,3 @@ pub const HTML_TAG: phf::Set<&'static str> = phf_set! {
     "wbr",
     "xmp",
 };
-
-/// set of reserved HTML tag names definition
-/// if it's not reserved, then it can have aria-* roles, states, and properties
-/// Reference: <https://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules#ax_aria_12>
-/// Reference: <https://www.w3.org/TR/html-aria/#rules-wd>
-/// Reference: <https://github.com/A11yance/aria-query/blob/v5.3.2/src/domMap.js>
-pub const RESERVED_HTML_TAG: phf::Set<&'static str> = phf_set! {
-    "base",
-    "col",
-    "colgroup",
-    "head",
-    "html",
-    "link",
-    "meta",
-    "noembed",
-    "noscript",
-    "param",
-    "picture",
-    "script",
-    "source",
-    "style",
-    "title",
-    "track",
-};

crates/oxc_linter/src/rules/eslint/prefer_exponentiation_operator.rs

@@ -67,7 +67,7 @@ impl Rule for PreferExponentiationOperator {
                 }
 
                 if let Expression::Identifier(ident) = member_expr.object().without_parentheses() {
-                    if GLOBAL_OBJECT_NAMES.contains(ident.name.as_str())
+                    if GLOBAL_OBJECT_NAMES.contains(&ident.name.as_str())
                         && ctx.is_reference_to_global_variable(ident)
                     {
                         ctx.diagnostic(prefer_exponentian_operator_diagnostic(call_expr.span));

crates/oxc_linter/src/rules/jsx_a11y/aria_unsupported_elements.rs

@@ -51,7 +51,7 @@ impl Rule for AriaUnsupportedElements {
     fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
         if let AstKind::JSXOpeningElement(jsx_el) = node.kind() {
             let el_type = get_element_type(ctx, jsx_el);
-            if RESERVED_HTML_TAG.contains(&el_type) {
+            if RESERVED_HTML_TAG.contains(&el_type.as_ref()) {
                 for attr in &jsx_el.attributes {
                     let attr = match attr {
                         JSXAttributeItem::Attribute(attr) => attr,

crates/oxc_linter/src/rules/unicorn/new_for_builtins.rs

@@ -108,7 +108,7 @@ fn is_expr_global_builtin<'a, 'b>(
             return None;
         };
 
-        if !GLOBAL_OBJECT_NAMES.contains(&ident.name) {
+        if !GLOBAL_OBJECT_NAMES.contains(&ident.name.as_str()) {
             return None;
         }
 

crates/oxc_linter/src/rules/unicorn/no_document_cookie.rs

@@ -122,7 +122,7 @@ fn is_document_cookie_reference<'a, 'b>(
             }
 
             if let Expression::Identifier(ident) = member_expr.object().without_parentheses() {
-                if !GLOBAL_OBJECT_NAMES.contains(ident.name.as_str()) {
+                if !GLOBAL_OBJECT_NAMES.contains(&ident.name.as_str()) {
                     return false;
                 }
             }

crates/oxc_linter/src/rules/unicorn/prefer_number_properties.rs

@@ -61,7 +61,7 @@ impl Rule for PreferNumberProperties {
                     return;
                 };
 
-                if GLOBAL_OBJECT_NAMES.contains(ident_name.name.as_str()) {
+                if GLOBAL_OBJECT_NAMES.contains(&ident_name.name.as_str()) {
                     match member_expr.static_property_name() {
                         Some("NaN") => {
                             ctx.diagnostic(prefer_number_properties_diagnostic(
@@ -114,7 +114,7 @@ fn extract_ident_from_expression<'b>(expr: &'b Expression<'_>) -> Option<&'b str
                 return None;
             };
 
-            if GLOBAL_OBJECT_NAMES.contains(ident_name.name.as_str()) {
+            if GLOBAL_OBJECT_NAMES.contains(&ident_name.name.as_str()) {
                 member_expr.static_property_name()
             } else {
                 None