Enable phan and phpstan #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
commented
Jun 16, 2023
Comment on lines
+69
to
+70
| ['a8', decoct((int) str_pad($this->uid, 7, '0', STR_PAD_LEFT))], | ||
| ['a8', decoct((int) str_pad($this->gid, 7, '0', STR_PAD_LEFT))], |
There was a problem hiding this comment.
phan correctly complains that an decoct must be passed an int
phil-davis
commented
Jun 16, 2023
| * @return string unsigned checksum | ||
| * @return float|int unsigned checksum |
There was a problem hiding this comment.
This function does actually return a number (usually an int, but if the number is big, then it could end up being a float.
phil-davis
commented
Jun 16, 2023
| @@ -149,7 +149,7 @@ public function finalize() { | |||
| * Initialize a file stream | |||
| * | |||
| * @param string $name file path or just name | |||
| * @param int $type type of the item | |||
| * @param int|string $type type of the item | |||
There was a problem hiding this comment.
Some code passes an int "magic number", other code passes a single char like "x"
phil-davis
commented
Jun 16, 2023
| * @link http://www.freebsd.org/cgi/man.cgi?query=tar&sektion=5&manpath=FreeBSD+8-current tar / PAX spec | ||
| */ | ||
| protected function paxGenerate($fields) { | ||
| $lines = ''; | ||
| foreach ($fields as $name => $value) { | ||
| // build the line and the size | ||
| $line = ' ' . $name . '=' . $value . "\n"; | ||
| $size = \strlen(\strlen($line)) + \strlen($line); | ||
| $size = \strlen((string) \strlen($line)) + \strlen($line); |
There was a problem hiding this comment.
strlen needs to be passed a string - added an explicit cast otherwise phan complains.
|
https://drone.owncloud.com/owncloud/TarStreamer/23/3/3 |
DeepDiver1975
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.