New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drone CI #26
Drone CI #26
Conversation
You can fully drop all the steps regarding:
This is just a tiny library - no owncloud app. see the travis.yaml as reference. |
Yes, I pasted in the "standard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the databases -
done - yes, that made no sense at all |
mind adding php 8.0 and 8.1? also having sqlite in the step name feels just wrong ... |
and there is still a step called |
also a step |
OK - I need to get rid of all the pieces related to core. I will have to cleanup all the logic of |
I can help out to make the code php8+ ready if you like..... In case there is anything to be done. Thanks a lot so far.... |
https://drone.owncloud.com/owncloud/TarStreamer/14/5/4 I really do need to get rid of anything that tries to use core! |
@DeepDiver1975 I cleaned up a lot of the excess drone starlark. I can easily enable phan and/or phpstan later if needed. unit tests pass on PHP 7.4 8.0 8.1 anything else needed for this "first pass" at getting it going? If this seems enough to get started, then I will squash some of the related commits together and then merge. |
Always interesting to see how an easy travis.yaml with 22 lines explodes into a 800+ lines drone ci file 🙈 anyway 👍 |
Issue #21
I did the following things:
.drone.star
that has all the "bells-and-whistles" used in CI for the oC10 apps. That gives flexibility to run whatever parts are wanted (code-style, phpunit, phan, phpstan...). And if stuff is fixed or enhanced in the "standard".drone.star
then the changes can be "mindlessly" applied the same here. (It gets annoying when some repos have different starlark code, and someone has to keep thinking about how to apply changes)public constant
declarations).drone.star
so that it installs php7.4-xdebug in the unit test pipeline. It uses its own locally-selected version of phpunit. The CI uses phpunit 9.6 with PHP 7.4. That decouples it from the unneeded core (many of the oC10 apps just run whatever phpunit version comes with core, we don't want to be hitched to that!)Do we want the code-style changes? (if not, I can remove those and not run code-style in CI)
Do we want to still support PHP 7.1 and up? Or drop the older PHP versions?
ToDo: sort out the unnecessary CI pipeline steps that install core... - this is not actually an oC10 app but I have used the "oC10 app" starlark code as an easy "template"