Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditions in Bun.build #9234

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

#9106 added support for bun --conditions and bun build --conditions, but left out passing conditions to Bun.build . This adds it

How did you verify your code works?

There is a test

Copy link
Member

@zackradisic zackradisic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jarred-Sumner Jarred-Sumner merged commit 1424a19 into main Mar 4, 2024
26 of 29 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/support-conditions-in-bun-build branch March 4, 2024 07:52
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Copy link
Contributor

github-actions bot commented Mar 4, 2024

@Jarred-Sumner 1 files with test failures on bun-darwin-x64:

View test output

#8569064c46f61a4775791b4352ff8b62ea531bd1

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Copy link
Contributor

github-actions bot commented Mar 4, 2024

❌🪟 @Jarred-Sumner, there are 12 test regressions on Windows x86_64

  • test\cli\run\env.test.ts
  • test\cli\run\transpiler-cache.test.ts
  • test\js\bun\dns\resolve-dns.test.ts
  • test\js\bun\http\fetch-file-upload.test.ts
  • test\js\bun\http\bun-server.test.ts
  • test\js\bun\shell\shelloutput.test.ts
  • test\js\bun\shell\throw.test.ts
  • test\js\node\dns\node-dns.test.js
  • test\js\node\process\process-args.test.js
  • test\js\web\fetch\body-stream-excess.test.ts
  • test\js\web\fetch\body-stream.test.ts
  • test\js\web\workers\worker.test.ts

Full Test Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants