shell: Improve ShellError
stacktrace
#9233
Merged
+49
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes errors thrown by Bun shell not showing the original stacktrace (Fixes #9182)
This is done by creating an Error object upfront upon creation of the
ShellPromise
.Creating an Error object shouldn't be too costly
I put breakpoints on the
computeErrorInfo...
functions inZigGlobalObject.cpp
to make sure we're not doing the expensive thing of computing the stack trace, didn't seem to hit any of those functions so think we should be goodHow did you verify your code works?
bun-debug test test-file-name.test
)