🌱 Updated the coverage for tests #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the `Makefile` to include the `-coverpkg=./...` flag when running tests. [Makefile] - Changed `SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out` to `SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out -coverpkg=./...` in the `Makefile` Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
raghavkaul
as code owners
naveensrinivasan
removed request for
justaugustus,
azeemshaikh38,
raghavkaul and
laurentsimon
naveensrinivasan
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2728 +/- ##
==========================================
+ Coverage 41.39% 49.87% +8.48%
==========================================
Files 124 156 +32
Lines 10164 11572 +1408
==========================================
+ Hits 4207 5772 +1565
+ Misses 5659 5450 -209
- Partials 298 350 +52 |
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
- Updated the `Makefile` to include the `-coverpkg=./...` flag when running tests. [Makefile] - Changed `SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out` to `SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out -coverpkg=./...` in the `Makefile` Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
- Updated the `Makefile` to include the `-coverpkg=./...` flag when running tests. [Makefile] - Changed `SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out` to `SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out -coverpkg=./...` in the `Makefile` Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefileto include the-coverpkg=./...flag when running tests.[Makefile]
SKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.outtoSKIP_GINKGO=1 go test -race -covermode=atomic -coverprofile=unit-coverage.out -coverpkg=./...in theMakefile#2203
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)