Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning alert proposes unsupported remediation #2129

Open
jenstroeger opened this issue Aug 6, 2022 · 1 comment
Open

Scanning alert proposes unsupported remediation #2129

jenstroeger opened this issue Aug 6, 2022 · 1 comment
Labels
kind/bug Something isn't working

Comments

@jenstroeger
Copy link

Describe the bug

Here’s a scanning alert: https://github.com/jenstroeger/python-package-template/security/code-scanning/38

It suggests to use pip with a hash instead of a pinned version. Alas, pip install does not have such a feature. While I understand the intention of the alert, we have good reason to pin instead of using a hash (doesn’t work) or a lock file/requirements.txt (too much clutter).

Expected behavior

No alert, or at least a better message.

Additional context

I’m tempted to say that this alert is a false positive; probably not, in which case the messaging ought to be clarified.

@laurentsimon
Copy link
Contributor

Hi, thanks for the report.

In you use case, the workflow has low privilege (pull_request trigger with only read permissions, no secrets available), so I agree scorecard should be handling this better. We have a tracking issue in #2018

Please let me know if this would address the problem.

@raghavkaul this would fall under the Impact field we described in #1874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Backlog - Bugs
Development

No branches or pull requests

2 participants