Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abuse detection in GitHub API requests #206

Closed
naveensrinivasan opened this issue Feb 21, 2021 · 2 comments
Closed

Implement abuse detection in GitHub API requests #206

naveensrinivasan opened this issue Feb 21, 2021 · 2 comments
Labels
GitHub kind/bug Something isn't working
Projects

Comments

@naveensrinivasan
Copy link
Member

The GitHub API would return 403 if there are too many requests for example cron running for a bunch of repositories

{
      "CheckName": "Signed-Releases",
      "Pass": false,
      "Confidence": 0,
      "Details": [
        "error, retrying: GET https://api.github.com/repos/activescaffold/active_scaffold/releases: 403 You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. []"
      ]
    },
    {
      "CheckName": "Signed-Tags",
      "Pass": false,
      "Confidence": 0,
      "Details": [
        "error, retrying: non-200 OK status code: 403 Forbidden body: \"{\\n  \\\"documentation_url\\\": \\\"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\\\",\\n  \\\"message\\\": \\\"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\\\"\\n}\\n\""
      ]
    }

Probably implement this solution
google/go-github#431 (comment)
https://github.com/hashicorp/terraform-provider-github/blob/fa73654b66e37b1fd8d886141d9c2974e24ba42f/github/transport.go#L42-L109 and it also has tests

@inferno-chromium inferno-chromium added the kind/bug Something isn't working label Mar 22, 2021
@justaugustus justaugustus added this to Backlog in Scorecard Feb 22, 2022
@afmarcum
Copy link
Contributor

afmarcum commented Aug 29, 2023

Does this bug still need to be addressed?
If there is no feedback in the next 7 days on whether this remains important for the project, then this issue will be closed.

@spencerschrock
Copy link
Contributor

We haven't been getting abuse detection responses in the cron this year. We also handle Retry-After as part of #2721, so maybe that's why we're not seeing them anymore.

@spencerschrock spencerschrock closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Scorecard automation moved this from Backlog to Done Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub kind/bug Something isn't working
Projects
Development

No branches or pull requests

4 participants