Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cache for imposter commit validation #462

Open
spencerschrock opened this issue Aug 29, 2023 · 0 comments
Open

Implement cache for imposter commit validation #462

spencerschrock opened this issue Aug 29, 2023 · 0 comments
Labels
api enhancement New feature or request

Comments

@spencerschrock
Copy link
Contributor

After enabling the feature in https://github.com/ossf/scorecard-webapp/releases/tag/v1.0.6, there was an increase in request latencies in the scorecard-api-prod.

p95: mostly unchanged, but now peaks as high at 3s
p99: approximately 1s -> 3.5s

Since the only hashes we lookup are for these repos:

  • "actions/checkout"
  • "ossf/scorecard-action"
  • "actions/upload-artifact"
  • "github/codeql-action"
  • "step-security/harden-runner"

it should be a pretty short list of hashes to keep track of. We can do a LRU if we're concerned about memory ballooning.
@spencerschrock spencerschrock added enhancement New feature or request api labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spencerschrock