New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling Error in Scorer #263

Open

nathannaveen opened this issue Nov 28, 2022 · 1 comment

Contributor

nathannaveen commented Nov 28, 2022

I am in the process of writing tests for ScoreRaw() and noticed a TODO: improve this behavior.

criticality_score/internal/scorer/scorer.go

Lines 87 to 92 in 14585f3

    
           // TODO: improve this behavior 
        
           v, err := strconv.ParseFloat(rawV, 64) 
        
           if err != nil { 
        
           	// Failed to parse raw into a float, ignore the field 
        
           	continue 
        
           }

In my opinion, it shouldn't ignore errors but should return them.

The text was updated successfully, but these errors were encountered:

Contributor Author

nathannaveen commented Nov 28, 2022

@calebbrown thoughts on this?

nathannaveen mentioned this issue

community: Is there a contributor ladder? #312

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment