Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a new release? #511

Open
pburkholder opened this issue May 1, 2024 · 3 comments
Open

Time for a new release? #511

pburkholder opened this issue May 1, 2024 · 3 comments

Comments

@pburkholder
Copy link

pburkholder commented May 1, 2024

We have an instance of Allstar running as a GitHub action that keeps crashing with

Killed
Error: Process completed with exit code 137.

about 15 seconds after starting a Binary Scan. The internet tells me this may be an OOMKiller at work. It looks like you've made some commits to address memory usage, could you make a Release with your latest fixes? Thanks!

@pburkholder
Copy link
Author

Correction - the apparent OOM killer kicks in about 15s after starting the scan

@jeffmendoza
Copy link
Member

Hi @pburkholder Will Do!
Yes, #496 changes how memory is held and frees the memory after each run. Originally we thought the cache would be small enough to keep around, but that hasn't worked out on the public instance.
#497 changes the number of concurrent workers, and allows config by env var. More concurrent workers means more memory in use at each time.

I'll get a release out tomorrow (Friday).

@jeffmendoza
Copy link
Member

That said, I'm still working through issues in the public instance, so there might be other problems with the binary scan. I'll keep debugging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants