test(model): Avoid unnecessary temporary list creations

fviernau · fviernau · commit 8ba5d1da1028 · 2025-02-11T15:04:59.000+01:00
Signed-off-by: Frank Viernau &lt;x9fviern@zeiss.com&gt;
diff --git a/model/src/test/kotlin/licenses/TestUtils.kt b/model/src/test/kotlin/licenses/TestUtils.kt
@@ -28,8 +28,8 @@ import org.ossreviewtoolkit.utils.spdx.SpdxSingleLicenseExpression
 
 fun containLicensesExactly(vararg licenses: String): Matcher<Iterable<ResolvedLicense>?> =
     neverNullMatcher { value ->
-        val expected = licenses.map { SpdxExpression.parse(it) as SpdxSingleLicenseExpression }.toSet()
-        val actual = value.map { it.license }.toSet()
+        val expected = licenses.mapTo(mutableSetOf()) { SpdxExpression.parse(it) as SpdxSingleLicenseExpression }
+        val actual = value.mapTo(mutableSetOf()) { it.license }
 
         containExactly(expected).test(actual)
     }

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,8 @@ import org.ossreviewtoolkit.utils.spdx.SpdxSingleLicenseExpression`
`28`	`28`
`29`	`29`	`fun containLicensesExactly(vararg licenses: String): Matcher<Iterable<ResolvedLicense>?> =`
`30`	`30`	`neverNullMatcher { value ->`
`31`		`- val expected = licenses.map { SpdxExpression.parse(it) as SpdxSingleLicenseExpression }.toSet()`
`32`		`- val actual = value.map { it.license }.toSet()`
	`31`	`+ val expected = licenses.mapTo(mutableSetOf()) { SpdxExpression.parse(it) as SpdxSingleLicenseExpression }`
	`32`	`+ val actual = value.mapTo(mutableSetOf()) { it.license }`
`33`	`33`
`34`	`34`	`containExactly(expected).test(actual)`
`35`	`35`	`}`