Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰馃拕 frontmatter not properly handled by typedoc #23

Closed
lukas-runge opened this issue Aug 29, 2023 · 6 comments
Closed

馃悰馃拕 frontmatter not properly handled by typedoc #23

lukas-runge opened this issue Aug 29, 2023 · 6 comments

Comments

@lukas-runge
Copy link
Contributor

lukas-runge commented Aug 29, 2023

Basically this just concerns README.md. All other files are not integrated into typedoc anyways. This file needs to have frontmatter for mdsvex for the endeavour in #15 to work out. 馃敟馃槆

Typedoc should just ignore frontmatter - currently it is shown like so:

Bildschirmfoto 2023-08-29 um 16 47 17
@hrueger
Copy link
Member

hrueger commented Aug 29, 2023

We could either create an issue in the typedoc repo, try to fix it there ourselves and make a PR or - as more of a quick fix - remove that before building the docs (in the gh action) using a regex.
What do you prefer?

@lukas-runge
Copy link
Contributor Author

As we use the typedoc --watch command for developing locally I would prefer fixing it in there. I haven't looked at it in more detail tho, so I can't evaluate if thats a practical solution. If we find it impractical then the quick fix is fine too as it will get the job done for now. 馃憣

@hrueger
Copy link
Member

hrueger commented Aug 30, 2023

OK, I did some research. According to their package.json it seems like typedoc is using marked as the markdown parser.
They have a (closed) issue about yaml frontmatter here: markedjs/marked#485
TLDR: won't be implemented, out of scope.

Should we create a new issue in the typedoc repo?

@lukas-runge
Copy link
Contributor Author

lukas-runge commented Aug 30, 2023

@hrueger thank you for the research!

Yeah, let's create a new issue over in typedoc. This could be as easy as removing the frontmatter before parsing. This could be a feature enabled thru the typedoc.json. Let's see what they think. 馃憤

@hrueger
Copy link
Member

hrueger commented Aug 30, 2023

Sure, see TypeStrong/typedoc#2381

@hrueger
Copy link
Member

hrueger commented Sep 5, 2023

fixed by TypeStrong/typedoc#2381. Theme was also updated to support the new typedoc version in mengxinssfd/typedoc-theme#3

@hrueger hrueger closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants