chore: fix typing for manifest_config param of push fn #141
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for push() the parameter
manifest_config
seems to me has the wrong type annotation.oras-py/oras/provider.py
Line 681 in 9527aa1
while it should be an
Optional[str]
considering it's used in push() to be passed to _parse_manifest_ref()
oras-py/oras/provider.py
Lines 785 to 786 in 9527aa1
which expect a
str
(and not adict
)oras-py/oras/provider.py
Lines 228 to 246 in 9527aa1
hope this helps :)