Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file.Store has race conditions on restoring the same named content #730

Closed
shizhMSFT opened this issue Mar 20, 2024 · 0 comments · Fixed by #731
Closed

file.Store has race conditions on restoring the same named content #730

shizhMSFT opened this issue Mar 20, 2024 · 0 comments · Fixed by #731
Labels
bug Something isn't working
Milestone
v2.5.0

Comments

@shizhMSFT
Copy link
Contributor

file.Store has race conditions on restoring the same named content, causing testing failures.

Output of failed test https://github.com/oras-project/oras-go/actions/runs/8358181822/job/22878904404:

=== RUN   TestStore_Predecessors
    file_test.go:2400: failed to push test content to src: 10: failed to restore duplicated file: "0c55e531aef3d9c23acecbf74a9ea864e6bdb0ec84b12a9cddfdbb26152d823c.blob": application/vnd.oci.image.index.v1+json: 0c55e531aef3d9c23acecbf74a9ea864e6bdb0ec84b12a9cddfdbb26152d823c.blob: duplicate name
@shizhMSFT shizhMSFT added the bug Something isn't working label Mar 20, 2024
@shizhMSFT shizhMSFT added this to the v2.5.0 milestone Mar 20, 2024
@shizhMSFT shizhMSFT mentioned this issue Mar 20, 2024
Merged
Wwwsylvia pushed a commit that referenced this issue Mar 21, 2024
@shizhMSFT
fix(file.Store): fix race condition on restoring the same named conte…
9b6f321 
…nt (#731)

Fix #730

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

fix(file.Store): fix race condition on restoring the same named content shizhMSFT/oras-go
1 participant
@shizhMSFT