Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use new built-in methods introduced before go 1.22 #726

Merged
merged 4 commits into from Mar 20, 2024
Merged

perf: use new built-in methods introduced before go 1.22 #726

merged 4 commits into from Mar 20, 2024

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Mar 19, 2024 •
edited

Changes:

  • chore: use built-in slices
  • perf: use built-in map clone
  • chore: use built-in map copy
  • perf: use slices.Sort instead of sort.Strings

Resolves: #713

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (8d139f0) to head (a1d93c0).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   75.62%   75.62%   -0.01%     
==========================================
  Files          64       63       -1     
  Lines        5994     5981      -13     
==========================================
- Hits         4533     4523      -10     
+ Misses       1078     1076       -2     
+ Partials      383      382       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT
chore: use built-in slices
b41114e 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
perf: use built-in map clone
ada641c 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
chore: use built-in map copy
8cbf8dd 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
perf: use slices.Sort instead of sort.Strings
a1d93c0 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT force-pushed the upgrade_perf branch 2 times, most recently from 7cb6519 to a1d93c0 Compare March 19, 2024 12:37
@shizhMSFT shizhMSFT changed the title chore: use new built-in methods introduced before go 1.22 perf: use new built-in methods introduced before go 1.22 Mar 19, 2024
@wangxiaoxuan273
Copy link
Contributor

LGTM although IANAM

Wwwsylvia
Wwwsylvia approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 4503c31 into oras-project:main Mar 20, 2024
9 checks passed
@shizhMSFT shizhMSFT deleted the upgrade_perf branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shift Go Support Window to [1.21, 1.22]
3 participants
@shizhMSFT @wangxiaoxuan273 @Wwwsylvia