Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift Go Support Window to [1.21, 1.22] #713

Closed
shizhMSFT opened this issue Feb 22, 2024 · 5 comments · Fixed by #715 or #726
Closed

Shift Go Support Window to [1.21, 1.22] #713

shizhMSFT opened this issue Feb 22, 2024 · 5 comments · Fixed by #715 or #726
Assignees
@dextrot
Labels
dependencies Pull requests that update a dependency file
Milestone
v2.5.0

Comments

@shizhMSFT
Copy link
Contributor

Go 1.22 is released with release notes!

It is time to shift the window for go support to [1.21, 1.22] by updating

  • go. mod
  • GitHub Actions
  • README.md

After shifting the golang support window, we can remove / update some internal implementations using the latest golang built-in libraries introduced in golang 1.21.
@shizhMSFT shizhMSFT added good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Feb 22, 2024
@shizhMSFT shizhMSFT added this to the v2.5.0 milestone Feb 22, 2024
@dextrot
Copy link
Contributor

dextrot commented Feb 26, 2024

Hi @shizhMSFT can you please assign this issue to me?

@shizhMSFT
Copy link
Contributor Author

@dextrot Sure. Thanks for contributing to oras-go.

You may follow #587 for references.

@dextrot
Copy link
Contributor

dextrot commented Feb 27, 2024

@dextrot Sure. Thanks for contributing to oras-go.

You may follow #587 for references.

Thank you @shizhMSFT

@dextrot dextrot mentioned this issue Feb 27, 2024
Merged
@shizhMSFT shizhMSFT removed the good first issue Good for newcomers label Mar 11, 2024
@shizhMSFT
Copy link
Contributor Author

@dextrot There is a build error in #715. Could you fix it according to #715 (review) as we need it in the next version v2.5.0, which is planned to be released in the near future? It is OK if you want to delegate it to other contributors.

@dextrot
Copy link
Contributor

dextrot commented Mar 11, 2024

@dextrot There is a build error in #715. Could you fix it according to #715 (review) as we need it in the next version v2.5.0, which is planned to be released in the near future? It is OK if you want to delegate it to other contributors.

Apologies, taking a look now.

@shizhMSFT shizhMSFT mentioned this issue Mar 12, 2024
Closed
shizhMSFT pushed a commit that referenced this issue Mar 19, 2024
@dextrot
build: bump go version (#715)
bf0d637 
This PR fixes #713
- bumps go version in `README.md`, `go.mod` and `GitHub Actions`.

---------

Signed-off-by: dextrot <131444479+dextrot@users.noreply.github.com>
Signed-off-by: SKM <131444479+dextrot@users.noreply.github.com>
@shizhMSFT shizhMSFT reopened this Mar 19, 2024
@shizhMSFT shizhMSFT mentioned this issue Mar 19, 2024
Merged
Wwwsylvia pushed a commit that referenced this issue Mar 20, 2024
@shizhMSFT
perf: use new built-in methods introduced before go 1.22 (#726)
4503c31 
Changes:
* chore: use built-in slices
* perf: use built-in map clone
* chore: use built-in map copy
* perf: use slices.Sort instead of sort.Strings

Resolves: #713

---------

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dextrot dextrot

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v2.5.0
2 participants
@shizhMSFT @dextrot