Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Use System.Logger instead of JUL where applicable #7792

Closed
tomas-langer opened this issue Oct 14, 2023 · 2 comments
Closed

4.x: Use System.Logger instead of JUL where applicable #7792

tomas-langer opened this issue Oct 14, 2023 · 2 comments
Assignees
Labels
4.x Version 4.x logging P3 team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon
Milestone

Comments

@tomas-langer
Copy link
Member

Revisit all usages of Java Util Logging (JUL) and replace relevant cases with System.Logger, so we can remove the dependency on java.logging from most of our modules.

The dependency is expected in:

  • helidon-logging-jul - the integration with JUL
  • temporary as a workaround for shutdown hook (I think in webserver), unless already abstracted (or abstract it into our logging implementations)
  • examples and test scopes (to correctly log in these cases)
@tomas-langer tomas-langer added logging 4.x Version 4.x labels Oct 14, 2023
@tomas-langer tomas-langer added this to the 4.x milestone Oct 14, 2023
@barchetta barchetta added P3 team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon labels Nov 9, 2023
@jbescos
Copy link
Member

jbescos commented May 22, 2024

Some modules contains public methods with dependencies to JUL:


public synchronized void setFormatter(Formatter newFormatter) throws SecurityException {

@jbescos jbescos self-assigned this May 22, 2024
jbescos added a commit to jbescos/helidon that referenced this issue May 23, 2024

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos added a commit to jbescos/helidon that referenced this issue May 23, 2024

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos added a commit to jbescos/helidon that referenced this issue May 23, 2024

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
jbescos added a commit that referenced this issue May 29, 2024

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
* 4.x: Use System.Logger instead of JUL where applicable #7792

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member

jbescos commented May 29, 2024

Merged

@jbescos jbescos closed this as completed May 29, 2024
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x logging P3 team-fix This issue is available for team members to be fixed. Should not require deep knowledge of Helidon
Projects
Archived in project
Development

No branches or pull requests

3 participants