Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Use LevelChangePropagator in logback examples #7737

Open
romain-grecourt opened this issue Oct 5, 2023 · 0 comments
Open

4.x: Use LevelChangePropagator in logback examples #7737

romain-grecourt opened this issue Oct 5, 2023 · 0 comments
Assignees
Labels
4.x Version 4.x enhancement New feature or request examples logging
Milestone

Comments

@romain-grecourt
Copy link
Contributor

Environment Details

  • Helidon Version: 4.0.0-RC1

Problem Description

When using jul-to-slf4j bridge with logback, the performance cost can be mitigated by using LevelChangePropagator.

<configuration debug="true">
  <contextListener class="ch.qos.logback.classic.jul.LevelChangePropagator">
    <resetJUL>true</resetJUL>
  </contextListener>
   <!-- rest of the configuration file .... -->
</configuration>

  • We should update examples/logging/slf4j to use it so that we demonstrate a best practice.
  • We should update the logback.xml snippet in the blog article
  • We should be setup the bridge using logging.properties instead of code as that is a "drop-in" and can be used regardless of the Helidon flavor:

logging.properties:

handlers=org.slf4j.bridge.SLF4JBridgeHandler
@romain-grecourt romain-grecourt added enhancement New feature or request examples 4.x Version 4.x labels Oct 5, 2023
@romain-grecourt romain-grecourt added this to the 4.0.0 milestone Oct 5, 2023
@barchetta barchetta added logging 3.x Issues for 3.x version branch and removed 4.x Version 4.x labels Oct 9, 2023
@barchetta barchetta modified the milestones: 4.0.0, 3.2.3 Oct 9, 2023
@barchetta barchetta changed the title Use LevelChangePropagator in logback examples 3.x: Use LevelChangePropagator in logback examples Oct 9, 2023
@barchetta barchetta modified the milestones: 3.2.3, 3.2.4, 3.x Nov 1, 2023
@barchetta barchetta modified the milestones: 3.x, 4.x Nov 6, 2023
@barchetta barchetta added 4.x Version 4.x and removed 3.x Issues for 3.x version branch labels Nov 6, 2023
@barchetta barchetta changed the title 3.x: Use LevelChangePropagator in logback examples 4x: Use LevelChangePropagator in logback examples Nov 6, 2023
@barchetta barchetta changed the title 4x: Use LevelChangePropagator in logback examples 4.x: Use LevelChangePropagator in logback examples Nov 6, 2023
Captain1653 added a commit to Captain1653/helidon that referenced this issue Apr 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
)
Captain1653 added a commit to Captain1653/helidon that referenced this issue Apr 12, 2024
romain-grecourt pushed a commit that referenced this issue May 2, 2024
* 4.x: Use LevelChangePropagator in examples/logging/slf4j (#7737)

* Add empty file name in logging.properties and debug option in logback configuration.
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Normal priority in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x enhancement New feature or request examples logging
Projects
Status: Normal priority
Development

No branches or pull requests

2 participants