Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sveltekit plugin is broken since vite@5.2.0-beta.1 #41

Closed
ZerdoX-x opened this issue Mar 23, 2024 · 6 comments
Closed

sveltekit plugin is broken since vite@5.2.0-beta.1 #41

ZerdoX-x opened this issue Mar 23, 2024 · 6 comments
Assignees

Comments

@ZerdoX-x
Copy link

ZerdoX-x commented Mar 23, 2024

Original issue (since it was not intended to be a breaking change from vite side) was opened here: vitejs/vite#16245

I have created the issue here, in case it can be solved on paraglide side, and so people could know if they stumble upon this, the current solution is to downgrade to vite@5.2.0-beta.0 or vite@5.1.6

UPD: I have tried to reproduce the issue without sveltekit, no luck

@ZerdoX-x ZerdoX-x changed the title vite plugin is broken since vite@5.2.0-beta.1 sveltekit plugin is broken since vite@5.2.0-beta.1 Mar 23, 2024
@arxpoetica
Copy link

arxpoetica commented Mar 23, 2024

I came here to post the same thing. Here's a reproduction of the bug, pre-and-post v5.1.6 Vite:

https://github.com/arxpoetica/inlang-sveltekit-vite-bug

I tried to reproduce this on StackBlitz for easier debugging, but that was creating issues on its own.

@LorisSigrist
Copy link
Member

Thanks for the repro, that's always really helpful!

Copy link
Member

LorisSigrist commented Mar 25, 2024

Seems like this bug was caused by a downstream issue in one of our our dependencies that was surfaced by a change in how vite loads the config. Will be fixed in the next release

@LorisSigrist LorisSigrist self-assigned this Mar 25, 2024
@ZerdoX-x
Copy link
Author

Seems like this bug was caused by a downstream issue in one of our our dependencies that was surfaced by a change in how vite loads the config. Will be fixed in the next release

@LorisSigrist seems like no need to fix anything. issue was fixed in vitejs/vite#16246

Copy link
Member

There _was_ a legitimate issue in paraglide, it just happened to be surfaced by a bug in vite. Either being fixed solves the issue. Great to see that the vite bug was fixed!

Thanks for the through issue + follow up!

@arxpoetica
Copy link

Can confirm this was fixed with the Vite fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants