Add tidy to the verify target #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of verifying, we should really be checking the status of `go mod tidy`. This can be done by adding the `tidy` target as a dependency of the `verify` target. This will be ussed during github workflows/CI to make sure everything is "tidied".
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 42.45% 42.45%
=======================================
Files 42 42
Lines 4011 4011
=======================================
Hits 1703 1703
Misses 2156 2156
Partials 152 152 ☔ View full report in Codecov by Sentry. |
everettraven
approved these changes
Apr 1, 2024
|
/lgtm |
grokspawn
approved these changes
Apr 1, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 191f5a7
into
operator-framework:master
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of verifying, we should really be checking the status of
go mod tidy. This can be done by adding thetidytarget as a dependency of theverifytarget. This will be ussed during github workflows/CI to make sure everything is "tidied".