Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules to support k8s v0.29.2 #319

Conversation

Neo2308
Copy link
Contributor

@Neo2308 Neo2308 commented Mar 19, 2024

Add support for kubernetes v0.29.2 in the Operator Framework/api project dependencies.

Includes changes from #313

Helps with operator-framework/operator-sdk#6651

OchiengEd and others added 5 commits March 19, 2024 11:50
Add support for kubernetes v0.29.2 in the Operator Framework api project
dependencies.

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Updated controller tools to v0.14.0.
Refreshed auto-generated files.
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.45%. Comparing base (4454fc8) to head (9d1191a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   42.45%   42.45%           
=======================================
  Files          42       42           
  Lines        4011     4011           
=======================================
  Hits         1703     1703           
  Misses       2156     2156           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neo2308 Neo2308 closed this Mar 23, 2024
@Neo2308 Neo2308 reopened this Mar 23, 2024
@Neo2308
Copy link
Contributor Author

Neo2308 commented Mar 23, 2024

@joelanford could you review this PR? Needs an approval for the workflows to run

@Neo2308
Copy link
Contributor Author

Neo2308 commented Mar 26, 2024

@everettraven @gallettilance can you help with this?

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@everettraven
Copy link
Contributor

@Neo2308 looks like this is failing a CI check

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@Neo2308
Copy link
Contributor Author

Neo2308 commented Mar 27, 2024

@everettraven I think it should be fixed now, need approval to run the tests again

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@Neo2308
Copy link
Contributor Author

Neo2308 commented Mar 28, 2024

@gallettilance @joelanford @kevinrizza the checks have passed now, could you review?

cc: @everettraven

Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I'm going to hold off on merging on a go ahead from @grokspawn and/or @tmshort as they have been orchestrating quite a few dependency bumps over the past few days across various operator-framework projects.

@everettraven
Copy link
Contributor

I just spoke with @grokspawn and @tmshort in our community slack channel, and the consensus was that they would like to hold dependency bump PRs until they have a chance to take a look and can help orchestrate it amongst the many other dependabot and other bumps they have been doing. They mentioned likely not having cycles to take a look until next week at the earliest. Apologies for the delay, and many thanks for your understanding @Neo2308 !

@tmshort
Copy link
Contributor

tmshort commented Apr 1, 2024

I'm going to look to see how bad this looks for OLM...

@grokspawn
Copy link
Contributor

/approve

We're ready to coordinate OLMv0 repos' k8s bumps, now.
Thank you so much for doing all the hard work here @Neo2308, and for your patience.

Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, grokspawn, Neo2308

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 11a4de6 into operator-framework:master Apr 1, 2024
6 checks passed
@Neo2308 Neo2308 deleted the feature/master/k8s-0_29_2-fix branch April 26, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants