Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field Subscription.Spec.Config.Annotations #312

Conversation

cognifloyd
Copy link
Contributor

@cognifloyd cognifloyd commented Jan 19, 2024

I need a way to annotate operator deployments to satisfy an admissions hook in my on-prem vanilla (not OCP) k8s clusters (The admissions hook requires annotations that say which team is responsible for that deployment).

After discussing in #olm-dev, it looks like Subscription is the best user (cluster admin) facing API to extend for this purpose, as other resources, like CSV, should generally be opaque to the cluster admin.

So, this PR adds an Annotations field to SubscriptionConfig (Subscription.Spec.Config.Annotations). Is there a better place for this? Or a better name?

For reference, here is a draft matching change I plan to make in the operator-lifecycle-manager repo once this PR is merged and a new api release is available:

@cognifloyd cognifloyd changed the title Add field Subscription.Spec.Config.DeploymentAnnotations Add field Subscription.Spec.Config.Annotations Jan 27, 2024
@kevinrizza
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2024
Copy link

openshift-ci bot commented Jan 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cognifloyd, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (75b2af0) 42.64% compared to head (915b186) 42.58%.

Files Patch % Lines
pkg/operators/v1alpha1/zz_generated.deepcopy.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   42.64%   42.58%   -0.06%     
==========================================
  Files          42       42              
  Lines        3583     3588       +5     
==========================================
  Hits         1528     1528              
- Misses       1903     1908       +5     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0eaaa1f into operator-framework:master Jan 27, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants