-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[srp-server] refine build flags for SRP server and Advertising Proxy #2763
Merged
+54
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
===========================================
- Coverage 55.77% 44.18% -11.60%
===========================================
Files 87 113 +26
Lines 6890 13588 +6698
Branches 0 965 +965
===========================================
+ Hits 3843 6004 +2161
- Misses 3047 7266 +4219
- Partials 0 318 +318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cf546d1
to
6dff199
Compare
85f83bb
to
b0e3f87
Compare
Irving-cl
reviewed
Mar 14, 2025
c9731d8
to
81e7e25
Compare
Irving-cl
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jwhui
reviewed
Mar 19, 2025
81e7e25
to
eb9a714
Compare
eb9a714
to
feeb501
Compare
jwhui
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a macro
OTBR_ENABLE_SRP_SERVER
to indicate whether the SRP server feature is enabled in OT. In this way we can use this macro instead ofOTBR_ENABLE_SRP_ADVERTISING_PROXY
to guard the code block that depends on theotSrpServer*
API.This PR also introduces a CMake option
OTBR_OT_SRP_ADV_PROXY
to configure whether to use the OT core Advertising Proxy.