Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[srp-server] refine build flags for SRP server and Advertising Proxy #2763

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

superwhd
Copy link
Contributor

@superwhd superwhd commented Mar 13, 2025

This PR introduces a macro OTBR_ENABLE_SRP_SERVER to indicate whether the SRP server feature is enabled in OT. In this way we can use this macro instead of OTBR_ENABLE_SRP_ADVERTISING_PROXY to guard the code block that depends on the otSrpServer* API.

This PR also introduces a CMake option OTBR_OT_SRP_ADV_PROXY to configure whether to use the OT core Advertising Proxy.

@Irving-cl Irving-cl self-requested a review March 13, 2025 09:02
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.18%. Comparing base (2b41187) to head (feeb501).
Report is 984 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2763       +/-   ##
===========================================
- Coverage   55.77%   44.18%   -11.60%     
===========================================
  Files          87      113       +26     
  Lines        6890    13588     +6698     
  Branches        0      965      +965     
===========================================
+ Hits         3843     6004     +2161     
- Misses       3047     7266     +4219     
- Partials        0      318      +318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@superwhd superwhd force-pushed the otbr-srp-server branch 4 times, most recently from cf546d1 to 6dff199 Compare March 13, 2025 15:30
@superwhd superwhd requested a review from abtink March 13, 2025 15:54
@superwhd superwhd marked this pull request as ready for review March 13, 2025 15:55
@superwhd superwhd removed the request for review from abtink March 14, 2025 02:05
@superwhd superwhd force-pushed the otbr-srp-server branch 4 times, most recently from c9731d8 to 81e7e25 Compare March 14, 2025 05:17
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@superwhd superwhd requested a review from jwhui March 19, 2025 04:04
@jwhui jwhui changed the title [srp-server] refine the macros and build options for SRP server and Advertising Proxy [srp-server] refine build flags for SRP server and Advertising Proxy Mar 19, 2025
@jwhui jwhui merged commit 324b654 into openthread:main Mar 19, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants