Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[border agent] refactor dbus meshcop txt update #2756

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

Irving-cl
Copy link
Contributor

This PR refactors the MeshCoP TXT update method in BorderAgent.

This is a DBUS method for vendors to update their vendor MeshCoP TXT values. The current call stack is:

DBus Handler -> ThreadHelper MeshCoP update callback -> BorderAgent Handle MeshCoP update

ThreadHelper is totally unnecessary here. So the new stack is simpler:

DBus Handler -> BorderAgent Handle MeshCoP update

Another intention is to unbind the BorderAgent module from ThreadHelper so that it can works in NCP design.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.77%. Comparing base (2b41187) to head (44bd6d2).
Report is 978 commits behind head on main.

Files with missing lines Patch % Lines
src/dbus/server/dbus_thread_object_rcp.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2756       +/-   ##
===========================================
- Coverage   55.77%   43.77%   -12.00%     
===========================================
  Files          87      110       +23     
  Lines        6890    13411     +6521     
  Branches        0      956      +956     
===========================================
+ Hits         3843     5871     +2028     
- Misses       3047     7230     +4183     
- Partials        0      310      +310     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Good catch!

@Irving-cl Irving-cl force-pushed the refactor_meshcop_txt_update branch from 7004089 to 4744583 Compare March 11, 2025 09:45
@Irving-cl Irving-cl requested a review from jwhui March 11, 2025 09:48
@Irving-cl Irving-cl force-pushed the refactor_meshcop_txt_update branch from 4744583 to 9822cf8 Compare March 12, 2025 16:36
@jwhui jwhui force-pushed the refactor_meshcop_txt_update branch from 9822cf8 to 44bd6d2 Compare March 13, 2025 01:53
@jwhui jwhui merged commit 6e099bc into openthread:main Mar 13, 2025
31 checks passed
@Irving-cl Irving-cl deleted the refactor_meshcop_txt_update branch March 21, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants