Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github-action] enhance ncp mode workflow #2563

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Irving-cl
Copy link
Contributor

@Irving-cl Irving-cl commented Oct 25, 2024

This PR enhances the ncp_mode github workflow in CI.

A few enhancement is done:

  1. Build docker image in the workflow for testing the border routing functionality.
  2. Change the usage of ncp_mode script. Use the same parameter style as script/test.
  3. Accelerate the workflow by avoiding building unnecessary dependencies: openthread library (in bootstrap), unit test, OTBR web

@Irving-cl Irving-cl added github_actions Pull requests that update GitHub Actions code enhancement P2 comp: ncp labels Oct 25, 2024
@Irving-cl Irving-cl force-pushed the update_ncp_mode_test_script branch from baf9fae to f5328c2 Compare October 25, 2024 04:13
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.92%. Comparing base (2b41187) to head (04fe616).
Report is 846 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2563      +/-   ##
==========================================
- Coverage   55.77%   45.92%   -9.86%     
==========================================
  Files          87      104      +17     
  Lines        6890    12381    +5491     
  Branches        0      903     +903     
==========================================
+ Hits         3843     5686    +1843     
- Misses       3047     6384    +3337     
- Partials        0      311     +311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl force-pushed the update_ncp_mode_test_script branch 5 times, most recently from 3aa8e0e to a743f32 Compare October 25, 2024 05:58
@Irving-cl Irving-cl changed the title [tests] enhance ncp mode test script [github-action] enhance ncp mode workflow Oct 25, 2024
@Irving-cl Irving-cl requested a review from bukepo October 25, 2024 06:15
@Irving-cl Irving-cl marked this pull request as ready for review October 25, 2024 06:16
@Irving-cl Irving-cl force-pushed the update_ncp_mode_test_script branch from a743f32 to fe0d1f3 Compare October 26, 2024 04:05
@Irving-cl Irving-cl requested a review from jwhui October 26, 2024 04:06
@Irving-cl Irving-cl mentioned this pull request Oct 26, 2024
17 tasks

Verified

This commit was signed with the committer’s verified signature.
timdorr Tim Dorr
@Irving-cl Irving-cl force-pushed the update_ncp_mode_test_script branch from fe0d1f3 to 04fe616 Compare October 29, 2024 01:10
@Irving-cl Irving-cl requested a review from jwhui October 29, 2024 01:10
@jwhui jwhui merged commit 59f89f0 into openthread:main Oct 29, 2024
32 checks passed
@Irving-cl Irving-cl deleted the update_ncp_mode_test_script branch October 30, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ncp enhancement github_actions Pull requests that update GitHub Actions code P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants