Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread-host] implement schedule migration for rcp host #2559

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR implements the ScheduleMigration method in RcpHost.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.31%. Comparing base (2b41187) to head (05bfefb).
Report is 852 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/rcp_host.cpp 61.11% 6 Missing and 1 partial ⚠️
tests/gtest/test_rcp_host_api.cpp 88.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2559      +/-   ##
==========================================
- Coverage   55.77%   46.31%   -9.47%     
==========================================
  Files          87      104      +17     
  Lines        6890    12484    +5594     
  Branches        0      906     +906     
==========================================
+ Hits         3843     5782    +1939     
- Misses       3047     6389    +3342     
- Partials        0      313     +313     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl force-pushed the rcp_host_schedule_migration branch 2 times, most recently from 34ed00b to 7285028 Compare October 30, 2024 05:58
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui October 30, 2024 07:26
@Irving-cl Irving-cl force-pushed the rcp_host_schedule_migration branch from 7285028 to 05bfefb Compare October 30, 2024 07:28
@jwhui jwhui changed the title [thread host] implement schedule migration for rcp host [thread-host] implement schedule migration for rcp host Nov 1, 2024
@Irving-cl Irving-cl requested a review from jwhui November 1, 2024 05:24
@jwhui jwhui merged commit 5c66507 into openthread:main Nov 1, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants