Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] fix: rename of Dataset to ActiveDataset in otbr open-api.yaml #2557

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

harterSe
Copy link
Contributor

There was an link to an not existing component which resulted in an error when generating an open api client.

The error was in the Route

/node/dataset/active(get)

The missing component was:
$ref: "#/components/schemas/Dataset"

I changed the route to use the existing component:
$ref: "#/components/schemas/ActiveDataset"

Copy link

google-cla bot commented Oct 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@harterSe harterSe changed the title fix: rename of Dataset to ActiveDataset in otbr open-api.yaml [rest] fix: rename of Dataset to ActiveDataset in otbr open-api.yaml Oct 22, 2024
Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.42%. Comparing base (2b41187) to head (56233d5).
Report is 841 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2557       +/-   ##
===========================================
- Coverage   55.77%   45.42%   -10.36%     
===========================================
  Files          87      102       +15     
  Lines        6890    12222     +5332     
  Branches        0      895      +895     
===========================================
+ Hits         3843     5552     +1709     
- Misses       3047     6368     +3321     
- Partials        0      302      +302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwhui jwhui self-requested a review October 23, 2024 09:17
Copy link
Member

@jwhui jwhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui jwhui merged commit 952fc6a into openthread:main Oct 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants