[netif] add wpan multicast group join for NCP #2478
Merged
+311
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
46cb697 to
c45b27b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2478 +/- ##
===========================================
- Coverage 55.77% 45.70% -10.08%
===========================================
Files 87 100 +13
Lines 6890 11819 +4929
Branches 0 864 +864
===========================================
+ Hits 3843 5402 +1559
- Misses 3047 6127 +3080
- Partials 0 290 +290 ☔ View full report in Codecov by Sentry. |
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
2 times, most recently
from
ba312ac to
bbf2fd4
Compare
Irving-cl
changed the title
Irving-cl
added
P2
comp: thread controller
platform: posix
comp: ncp
and removed
work-in-progress
labels
superwhd
reviewed
Sep 12, 2024
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
bbf2fd4 to
abf2a30
Compare
superwhd
reviewed
Sep 12, 2024
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
abf2a30 to
babafd1
Compare
superwhd
approved these changes
Sep 12, 2024
sunytt
reviewed
Sep 13, 2024
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
babafd1 to
3b9c62a
Compare
sunytt
approved these changes
Sep 13, 2024
abtink
approved these changes
Sep 13, 2024
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
3b9c62a to
b214f73
Compare
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
2 times, most recently
from
b8ed379 to
0d4a0ee
Compare
bukepo
reviewed
Sep 14, 2024
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
0d4a0ee to
692e3b5
Compare
Irving-cl
force-pushed
the
netif_wpan_multicast_addr
branch
from
692e3b5 to
c69a206
Compare
bukepo
approved these changes
Sep 14, 2024
jwhui
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds wpan multicast group join functionality for NCP.
This PR allows the applications to join/leave multicast groups in the Thread network. The functionality is implemented by listening to MLD reports sent by kernel. And then the Netif module will send the join/leave request to the NCP and let NCP join/leave the multicast group. Previous work on this in OT: openthread/openthread#4687
In this PR,
NcpSpinel::Ip6MulAddrUpdateSubscriptionis implemented as empty. This will be implemented in a following PR. This PR adds a unit test case to verify that the MLD reports can be successfully received and handled.