Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[posix] add missing header guards, style fixes #9892

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

abtink
Copy link
Member

@abtink abtink commented Mar 4, 2024

This commit contains smaller changes in the posix platform modules:

  • Adds missing header guard checks.
  • Use consistent names for header guard defines.
  • Fix/update comments.

Copy link

size-report bot commented Mar 4, 2024

Size Report of OpenThread

Merging #9892 into main(88b2b5c).

name branch text data bss total
ot-cli-ftd main 465664 760 66332 532756
#9892 465664 760 66332 532756
+/- 0 0 0 0
ot-ncp-ftd main 435652 760 61544 497956
#9892 435652 760 61544 497956
+/- 0 0 0 0
libopenthread-ftd.a main 234945 0 40278 275223
#9892 234945 0 40278 275223
+/- 0 0 0 0
libopenthread-cli-ftd.a main 56919 0 8075 64994
#9892 56919 0 8075 64994
+/- 0 0 0 0
libopenthread-ncp-ftd.a main 31855 0 5916 37771
#9892 31855 0 5916 37771
+/- 0 0 0 0
ot-cli-mtd main 364640 760 51220 416620
#9892 364640 760 51220 416620
+/- 0 0 0 0
ot-ncp-mtd main 347292 760 46448 394500
#9892 347292 760 46448 394500
+/- 0 0 0 0
libopenthread-mtd.a main 158177 0 25182 183359
#9892 158177 0 25182 183359
+/- 0 0 0 0
libopenthread-cli-mtd.a main 39743 0 8059 47802
#9892 39743 0 8059 47802
+/- 0 0 0 0
libopenthread-ncp-mtd.a main 24735 0 5916 30651
#9892 24735 0 5916 30651
+/- 0 0 0 0
ot-cli-ftd-br main 534248 768 130876 665892
#9892 534248 768 130876 665892
+/- 0 0 0 0
libopenthread-ftd-br.a main 298180 5 104798 402983
#9892 298180 5 104798 402983
+/- 0 0 0 0
libopenthread-cli-ftd-br.a main 70552 0 8099 78651
#9892 70552 0 8099 78651
+/- 0 0 0 0
ot-rcp main 62248 564 20604 83416
#9892 62248 564 20604 83416
+/- 0 0 0 0
libopenthread-rcp.a main 9542 0 5052 14594
#9892 9542 0 5052 14594
+/- 0 0 0 0
libopenthread-radio.a main 18821 0 214 19035
#9892 18821 0 214 19035
+/- 0 0 0 0

This commit contains smaller changes in the `posix` platform modules:
- Adds missing header guard checks.
- Use consistent names for header guard defines.
- Fix/update comments.
@abtink abtink force-pushed the posix/style-fix branch from 083daac to e9a35d1 Compare March 5, 2024 17:50
@jwhui jwhui requested a review from superwhd March 5, 2024 21:23
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@jwhui jwhui merged commit d63da4f into openthread:main Mar 6, 2024
101 checks passed
superwhd added a commit to superwhd/openthread that referenced this pull request Sep 2, 2024
Bug: 333301206

* github/main:
  [mle] MTD to handle udp time sync message (openthread#9978)
  [plat-utils] enhance `otMacFrameDoesAddrMatch()` (openthread#9997)
  [netdata-publisher] distinguish SRP/DNS unicast entries (openthread#9937)
  [logging] introduce `LogWarnOnError()` for standardized error logging (openthread#9996)
  [test] add tests for multi-BR network resilience during BR removal (openthread#9990)
  [srp-sever] add `LogError()` (openthread#9992)
  [dataset] define `Dataset::Tlvs` type (openthread#9991)
  [ip6] allow delivering RLOC/ALOC traffic to host (openthread#9987)
  [mle] simplify `CheckReachablity()` (openthread#9989)
  [srp-server] retry other ports when failing to `prepareSocket` (openthread#9981)
  [link-metrics] fix race condition (openthread#9986)
  [doc] use space char instead of tabs in `ot_config_doc.h` (openthread#9983)
  github-actions: bump actions/checkout from 4.1.1 to 4.1.2 (openthread#9982)
  [mesh-forwarder] update `CheckReachablity()` to handle malformed messages (openthread#9976)
  [netata] simplify `RemoveTemporaryData()` (openthread#9975)
  [cli] `netdata show` to support filtering by RLOC16 (openthread#9969)
  [mle] improve MLE module comments (openthread#9972)
  [cli] fix CoAP response code for POST 2.03 -> 2.04 per RFC 7252 (openthread#9971)
  [mle] include child RLOC16 in the logs from `HandleTimeTick()` (openthread#9968)
  [netdata] refactor `MutableNetworkData` methods for code organization (openthread#9970)
  [routing-manager] set extra options to append to emitted RAs (openthread#9945)
  [test] add `tcat` unit tests (openthread#9953)
  [cli] add `OutputNetworkData()` (openthread#9965)
  [routing-manager] employ RA hash tracking to detect self-originating RAs (openthread#9939)
  [channel-manager] add local csl channel selection on SSED (openthread#9641)
  [netdata] add `FindRlocs()` to retrieve RLOC16 of entries (openthread#9961)
  [version] introduce `OT_THREAD_VERSION_1_4` (openthread#9946)
  github-actions: bump actions/download-artifact from 4.1.1 to 4.1.4 (openthread#9963)
  [config] update docs for `SED_BUFFER_SIZE` & `SED_DATAGRAM_COUNT` (openthread#9962)
  [spinel] extract log module from radio spinel (openthread#9957)
  [mle] simplify `HandleTimeTick()` code related to aging routers (openthread#9955)
  [mle] retain direct child cache entries on Addr Solicit Response TX (openthread#9956)
  [test] simplify `test_pskc` unit test (openthread#9952)
  [cli] move `Process{Get/Set/Enable/Disable}` methods to Utils class (openthread#9951)
  [simulation] add simulation tests framework for tcat (openthread#9724)
  [coap] fix copying option (openthread#9894)
  github-actions: bump docker/setup-buildx-action from 3.0.0 to 3.2.0 (openthread#9941)
  [routing-manager] simplify `Ip6::Nd` type usage (openthread#9938)
  [thread-cert] use `unittest` assert methods (openthread#9936)
  [lib] include `(void)` in function prototype in `reset_util.h` (openthread#9934)
  [routing-manager] update use of `Ip6::Nd::Option` enumerator (openthread#9931)
  [posix] remove use of core-internal types in `netif.cpp` platform (openthread#9928)
  [test] enhance `test_netdata_publisher` robustness (openthread#9932)
  [thread-cert] use `ROUTER_STARTUP_DELAY` in `test_detach` (openthread#9933)
  [mle] disable MLE retransmissions when detaching (openthread#9929)
  [simulation] allow specify local host (openthread#9925)
  [routing-manager] construct RA dynamically using `Heap::Array` (openthread#9924)
  [posix] ensure module names are included in platform logs (openthread#9920)
  [tests] fix `test_manual_maddress.py` (openthread#9923)
  [thread-cert] set device mode in `test_mle_msg_key_seq_jump` (openthread#9921)
  [posix] add IPv6 address helper functions in `Ip6Utils` (openthread#9917)
  [daemon] always initialize the OT CLI when setting up the daemon (openthread#9919)
  [misc] remove stale forward declaration (openthread#9911)
  github-actions: bump actions/upload-artifact from 4.2.0 to 4.3.1 (openthread#9914)
  [docs] add documentation for CLI `dataset updater` command (openthread#9905)
  [test] add `test_key_rotation_and_key_guard_time` (openthread#9906)
  [srp-server] add snoop cache entries for registered host addresses (openthread#9881)
  [key-manager] update how key guard time is determined and applied (openthread#9871)
  [toranj-config] disable `OT_BORDER_ROUTING` on NCP builds (openthread#9907)
  [simulation] implement `otPlatInfraIf` APIs in simulation platform (openthread#9895)
  [posix] add otSysCliInitUsingDaemon API (openthread#9897)
  [routing-manager] delay sending RAs until after initial policy evaluation (openthread#9896)
  [posix] add missing header guards, style fixes (openthread#9892)
  [border-agent] mechanism to use ephemeral key (openthread#9435)
  [posix] enable building `infra_if.cpp` on macOS (openthread#9891)
  [string] return `0` if `nullptr` is passed to `StringLength` (openthread#9886)
  [posix] fix member var access from static `CreateIcmp6Socket()` (openthread#9887)
  github-actions: bump github/codeql-action from 3.23.2 to 3.24.6 (openthread#9890)
  github-actions: bump codecov/codecov-action from 3.1.4 to 4.0.2 (openthread#9877)
  [cli] add documentation for `nexthop` command in `README.md` (openthread#9882)
  [simulation] add `simul_utils.h` for socket operation helpers (openthread#9879)
  [message] track received `ThreadLinkInfo` in `Message` metadata (openthread#9878)
  [spinel] drop received frames between RCP disable and reset (openthread#9793)
  [link-quality] prevent overflow in `LqiAverager` calculation (openthread#9876)
  [cli] add `@moreinfo` Doxygen tags to reference CoAPS Concepts Guide (openthread#9867)
  [core] use `NumericLimits<>` constants (openthread#9875)

Change-Id: I65a1c577c22335916c3ba68f164a76b6d1409831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants