Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: denylist: skip coreos.unique.boot.failure on aarch64 #1401

Merged

Conversation

marmijo
Copy link
Contributor

@marmijo marmijo commented Nov 28, 2023

coreos.unique.boot.failure has been failing on aarch64 builds
and coreos.ignition.failure has been failing on RHCOS in general.
Let's denylist them and add a snooze while we investigate
the issues.

See: coreos/coreos-assembler#3670 and coreos/coreos-assembler#3669

EDIT: updated to add coreos.ignition.failure

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@marmijo
Copy link
Contributor Author

marmijo commented Nov 28, 2023

/retest

@jlebon
Copy link
Member

jlebon commented Nov 28, 2023

I guess let's also add coreos.ignition.failure with tracker coreos/coreos-assembler#3670 while we're here?

Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait I typed too fast. Jlebon comment makes a lot of sense

`coreos.unique.boot.failure` has been failing on aarch64 builds
and `coreos.ignition.failure` has been failing on RHCOS in general.
Let's denylist them and add a snooze while we investigate
the issues.

See: coreos/coreos-assembler#3670
and coreos/coreos-assembler#3669
@marmijo
Copy link
Contributor Author

marmijo commented Nov 29, 2023

@jlebon I updated the commit to also denylist coreos.ignition.failure

@jlebon
Copy link
Member

jlebon commented Nov 29, 2023

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbtrystram, jlebon, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jbtrystram,jlebon,marmijo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@jlebon
Copy link
Member

jlebon commented Nov 29, 2023

Looks like infra flake in the repos. (Or possibly due to the current shuffling around 4.15 branching.)

Since this is just adding denylist entries and our pipeline is broken on this, let's just get it in.

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

@jlebon jlebon changed the title denylist: skip coreos.unique.boot.failure on aarch64 NO-JIRA: denylist: skip coreos.unique.boot.failure on aarch64 Nov 29, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2023
@openshift-ci-robot
Copy link

@marmijo: This pull request explicitly references no jira issue.

In response to this:

coreos.unique.boot.failure has been failing on aarch64 builds
and coreos.ignition.failure has been failing on RHCOS in general.
Let's denylist them and add a snooze while we investigate
the issues.

See: coreos/coreos-assembler#3670 and coreos/coreos-assembler#3669

EDIT: updated to add coreos.ignition.failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3edd5e5 and 2 for PR HEAD 8c90ea6 in total

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

Looks like infra flake in the repos. (Or possibly due to the current shuffling around 4.15 branching.)

Since this is just adding denylist entries and our pipeline is broken on this, let's just get it in.

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b03c560 into openshift:master Nov 29, 2023
7 checks passed
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

@marmijo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants