Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest-rhel9.4: create os-release.rhel #1386

Merged
merged 1 commit into from
Oct 18, 2023
Merged

manifest-rhel9.4: create os-release.rhel #1386

merged 1 commit into from
Oct 18, 2023

Conversation

marmijo
Copy link
Contributor

@marmijo marmijo commented Oct 17, 2023

Several RHCOS kola tests are failing because the file os-release.rhel cant be found.
Change the extension of the os-release file in order to better configure this variant
to look like a RHEL based RHCOS instead of a C9S based one.

@marmijo
manifest-rhel9.4: create os-release.rhel
c0ee2c6 
Several RHCOS kola tests are failing because the file `os-release.rhel`
cant be found. Change the extension of the os-release file in order
to better configure this variant to look like a RHEL based RHCOS
instead of a C9S based one.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@marmijo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Oct 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 6c202cb into openshift:master Oct 18, 2023
7 checks passed
@jlebon
Copy link
Member

jlebon commented Oct 18, 2023

@marmijo If you still have it, it might be worth commenting here the error message from the test failures you got so it shows up in searches in the future.

@marmijo
Copy link
Contributor Author

marmijo commented Oct 18, 2023

The following tests were the failing ones:

  • ext.config.version.rhel-major-version
  • ext.config.version.rhel-matches-rhcos-build
+ variant=rhcos
+ case "${variant}" in
++ source /usr/lib/os-release.rhel
/usr/local/bin/kola-runext-rhel-major-version: line 17: /usr/lib/os-release.rhel: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlebon jlebon jlebon approved these changes

@jbtrystram jbtrystram Awaiting requested review from jbtrystram

@lukewarmtemp lukewarmtemp Awaiting requested review from lukewarmtemp

Assignees

@jlebon jlebon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marmijo @jlebon