-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RHEL 9.4 Variant #1378
Add RHEL 9.4 Variant #1378
Conversation
|
manifest-rhel-9.4.yaml
Outdated
packages: | ||
# We include the generic release package and tweak the os-release info in a | ||
# post-proces script | ||
- redhat-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- redhat-release | |
- centos(stream?)-release |
manifest-rhel-9.4.yaml
Outdated
# See: https://projects.engineering.redhat.com/browse/COREOS-1029 | ||
. /etc/os-release | ||
cat > /etc/motd <<EOF | ||
CentOS Stream CoreOS $VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CentOS Stream CoreOS $VERSION | |
Red Hat Enterprise Linux CoreOS $VERSION |
Let's fake the name.
manifest-rhel-9.4.yaml
Outdated
. /etc/os-release | ||
cat > /etc/motd <<EOF | ||
CentOS Stream CoreOS $VERSION | ||
Part of OKD ${OPENSHIFT_VERSION}, SCOS is a Kubernetes native operating system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of OKD ${OPENSHIFT_VERSION}, SCOS is a Kubernetes native operating system | |
Part of OpenShift ${OPENSHIFT_VERSION}, RHCOS is a Kubernetes native operating system |
manifest-rhel-9.4.yaml
Outdated
. /etc/os-release | ||
cat > /usr/lib/os-release <<EOF | ||
NAME="${NAME} CoreOS" | ||
ID="scos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ID="scos" | |
ID="rhcos" |
Add manifest, image, and extensions yaml files to support a new RHEL 9.4 Variant.
3ee38cc
to
111cdbe
Compare
Thanks! I forced pushed an update based on the review. |
- rhel-9.2-server-ose-4.15 | ||
|
||
# We include hours/minutes to avoid version number reuse | ||
automatic-version-prefix: "415.94.<date:%Y%m%d%H%M>" | ||
# This ensures we're semver-compatible which OpenShift wants | ||
automatic-version-suffix: "-" | ||
# Keep this is sync with the version in postprocess | ||
mutate-os-release: "4.15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also change this to target 4.14 instead of 4.15?
@marmijo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This branch is 4.15 so let's keep that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marmijo, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add the following files to support a RHEL 9.4 variant.
manifest-rhel-9.4.yaml
image-rhel-9.4.yaml -> image-rhel-coreos-9.yaml
extensions-rhel-9.4.yaml -> extensions-rhel-coreos-9.yaml
See: https://issues.redhat.com/browse/COS-2476