-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-7582, OCPBUGS-13754: overlay.d: move 30gcp-udev-rules overlay to RHCOS #1310
OCPBUGS-7582, OCPBUGS-13754: overlay.d: move 30gcp-udev-rules overlay to RHCOS #1310
Conversation
Dusty Mabe (1): manifests/fedora-coreos-base: re-organize arch includes package list comments Renata Ravanelli (1): Add google-compute-engine-guest-configs-udev package; drop 30gcp-udev-rules overlay
These files were dropped from the FCOS overlay in [1] because they are now being delivered via the google-compute-engine-guest-configs-udev subpackage. Until this package exists in RHEL we'll add an overlay to RHCOS with the rules (they have now been updated to match latest upstream). [1] coreos/fedora-coreos-config#2450
This is a fix for https://issues.redhat.com/browse/OCPBUGS-13754, which we'll then backport to 4.13. |
Note this should also be a fix for https://issues.redhat.com/browse/OCPBUGS-7582 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, mike-nguyen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dustymabe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick release-4.13 |
@travier: #1310 failed to apply on top of branch "release-4.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4.13 backport: #1312 |
/retitle OCPBUGS-7582, OCPBUGS-13754: overlay.d: move 30gcp-udev-rules overlay to RHCOS |
@dustymabe: Jira Issue OCPBUGS-13754: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-13754 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The bot only picks one Jira card apparently. This is for: |
These files were dropped from the FCOS overlay in [1] because
they are now being delivered via the google-compute-engine-guest-configs-udev
subpackage. Until this package exists in RHEL we'll add an overlay
to RHCOS with the rules (they have now been updated to match latest
upstream).
[1] coreos/fedora-coreos-config#2450