Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extension for ipsec #1308

Merged
merged 1 commit into from
Jun 12, 2023
Merged

add extension for ipsec #1308

merged 1 commit into from
Jun 12, 2023

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Jun 6, 2023

This include libreswan and NetworkManager-lireswan so customers can
configure it either through a NM plugin or directly

@openshift-ci openshift-ci bot requested review from aaradhak and ravanelli June 6, 2023 13:44
@cgwalters cgwalters mentioned this pull request Jun 6, 2023
Merged
@cgwalters
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@travier
Copy link
Member

travier commented Jun 7, 2023

LGTM. Let's link everything to https://issues.redhat.com/browse/OCPBU-633

@travier
Copy link
Member

travier commented Jun 7, 2023

Goes with openshift/machine-config-operator#3726

LorbusChris added a commit to LorbusChris/okd-machine-os that referenced this pull request Jun 8, 2023
@LorbusChris
Add RPMs for ipsec extension
e783ba6 
Adds the libreswan and NetworkManager-libreswan RPMs
so IPSec tunnels can be configured on the nodes.

see openshift/os#1308
@LorbusChris LorbusChris mentioned this pull request Jun 8, 2023
Closed
@yuvalk
add extension for ipsec
d0e57eb 
This include libreswan and NetworkManager-lireswan so customers can
configure it either through a NM plugin or directly

xref https://issues.redhat.com/browse/OCPBU-633
@yuvalk
Copy link
Contributor Author

yuvalk commented Jun 11, 2023

/test scos-9-build-test-metal

@travier travier mentioned this pull request Jun 12, 2023
Closed
travier
travier approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c546e95 and 2 for PR HEAD d0e57eb in total

@travier
Copy link
Member

travier commented Jun 12, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

@yuvalk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit abf7f1f into openshift:master Jun 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@aaradhak aaradhak Awaiting requested review from aaradhak

@ravanelli ravanelli Awaiting requested review from ravanelli

Assignees

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yuvalk @cgwalters @travier @openshift-ci-robot @openshift-merge-robot