tests/trust-cpu: support v6.x kernels #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL 10 will have a v6.x kernel (and RHEL 9.6 and onwards as an option). We'd like to do some early testing of RHCOS and OCP with that kernel since it also includes other major changes such as a new RPM name (`kernel-redhat`). Adapt this test to run fine on 6.x kernels, automatically noop'ing on versions where we know `CONFIG_RANDOM_TRUST_CPU` was removed as per coreos/fedora-coreos-tracker#1369. While we're here, use `architectures` to gate the whole test on x86_64 rather than noop'ing at runtime.
openshift-ci
bot
added
the
approved
cgwalters
reviewed
May 18, 2023
| fi | ||
| ok "random trust cpu" ;; | ||
| *) echo "Don't know how to test hardware RNG state on arch=$(arch)" ;; | ||
| *) echo "CPU trusting is always enabled" ;; |
There was a problem hiding this comment.
We're just trusting the trusting here...
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL 10 will have a v6.x kernel (and RHEL 9.6 and onwards as an option). We'd like to do some early testing of RHCOS and OCP with that kernel since it also includes other major changes such as a new RPM name (
kernel-redhat).Adapt this test to run fine on 6.x kernels, automatically noop'ing on versions where we know
CONFIG_RANDOM_TRUST_CPUwas removed as per coreos/fedora-coreos-tracker#1369.While we're here, use
architecturesto gate the whole test on x86_64 rather than noop'ing at runtime.