Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions-c9s: use match-base-evr: kernel for kernel-rt #1218

Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Mar 24, 2023

The kernel-rt merge has already happened in CentOS Stream 9. So using match-base-evr now works there. This means that rpm-ostree will guarantee that the kernel-rt package matches the version of the base kernel.

We don't build SCOS in the CoreOS pipelines today but let's exercise this knob as preparation for when the change propagates to RHEL.

The kernel-rt merge has already happened in CentOS Stream 9. So using
`match-base-evr` now works there. This means that rpm-ostree will
guarantee that the kernel-rt package matches the version of the base
kernel.

We don't build SCOS in the CoreOS pipelines today but let's exercise
this knob as preparation for when the change propagates to RHEL.
@openshift-ci openshift-ci bot requested review from prestist and travier March 24, 2023 16:28
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@cgwalters
Copy link
Member

We don't build SCOS in the CoreOS pipelines

We do though in Prow jobs here...and I still need to figure out the relationship of this and the OKD Tekton stuff.

That said, it looks like SCOS entirely fell over (recently?)

@jlebon
Copy link
Member Author

jlebon commented Mar 24, 2023

We don't build SCOS in the CoreOS pipelines

We do though in Prow jobs here...

I should've been more complete here. I mentioned the CoreOS pipelines because we currently have code there that checks in post that the versions match: coreos/fedora-coreos-pipeline#828. Once we can use this knob in RHCOS, we won't need that anymore (well, we'll still need it for older releases, but the check could be conditionalized).

@jlebon
Copy link
Member Author

jlebon commented Mar 27, 2023

/retest

@jlebon
Copy link
Member Author

jlebon commented Mar 31, 2023

CI is in a bad shape, but I've tested this locally.

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

CI is in a bad shape, but I've tested this locally.

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmarrero
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f8a59eb into openshift:master Mar 31, 2023
@jlebon jlebon deleted the pr/c9s-rt-match-base-evr branch April 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants