Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola-denylist: drop ext.config.shared.content-origins and ext.config.version.rhel-matches-rhcos-build #1217

Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Mar 23, 2023

See individual commits.

We're now on RHEL content for the `rhel-9.2` variant. For the `scos`
variant, the test already knows to no-op.
This passes now.

While we're here, add some comments in the test.
@openshift-ci openshift-ci bot requested review from cverna and jmarrero March 23, 2023 16:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 080f75f and 2 for PR HEAD f85080a in total

@jlebon
Copy link
Member Author

jlebon commented Mar 24, 2023

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-92-build-test-metal, ci/prow/rhcos-92-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

/override ci/prow/rhcos-92-build-test-metal
/override ci/prow/rhcos-92-build-test-qemu
/override ci/prow/scos-9-build-test-metal
/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3abd461 into openshift:master Mar 24, 2023
@jlebon jlebon deleted the pr/denylist-drop-content-origins branch April 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants