Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'AWS_REGION' to output when formatting credentials output #443

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Jun 6, 2024

What type of PR is this?

feature

What this PR does / Why we need it?

When outputting cloud credentials with the -o env flag, the current output will contain the region as AWS_DEFAULT_REGION. Looking at the AWS docs, this seems to be dropping in favor of AWS_REGION. Furthermore, some AWS SDKs don't even acknowledge the AWS_DEFAULT_REGION envar.

Resolves OSD-23927

Copy link

@rafael-azevedo rafael-azevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.58%. Comparing base (a8a9d8a) to head (33fdf6e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   44.58%   44.58%           
=======================================
  Files          63       63           
  Lines        5291     5291           
=======================================
  Hits         2359     2359           
  Misses       2615     2615           
  Partials      317      317           
Files Coverage Δ
pkg/credentials/aws.go 16.66% <100.00%> (ø)

@openshift-ci openshift-ci bot requested review from typeid and wanghaoran1988 June 6, 2024 14:18

Verified

This commit was signed with the committer’s verified signature.
XSAM Sam Xie
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hectorakemp
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, hectorakemp, rafael-azevedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3414c50 into openshift:main Jun 6, 2024
7 checks passed
@AlexVulaj AlexVulaj deleted the use_aws_region branch June 6, 2024 14:37
@AlexVulaj AlexVulaj changed the title use 'AWS_REGION' instead of 'AWS_DEFAULT_REGION' when formatting credentials output add 'AWS_REGION' to output when formatting credentials output Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants