New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Allow nullable date in VerifyOptions #1644

Merged

twiss merged 1 commit into openpgpjs:main from oofdog:main

Oct 23, 2023

Contributor

doggge77 commented May 17, 2023

It seems like the library allows passing null when calling verify, as it checks for null here

openpgpjs/src/key/helper.js

Line 73 in 400b163

if (normDate !== null) {
openpgpjs/src/util.js

Line 78 in 400b163

normalizeDate: function (time = Date.now()) {

but the TS declaration doesn't reflect that.


          Allow nullable date in VerifyOptions

8a2bb98

twiss approved these changes

View reviewed changes

Member

twiss left a comment

👍 Thanks for the PR, and apologies for the delayed review!

twiss merged commit 1111322 into openpgpjs:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment