Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing function declaration in SubKey type #1587

Closed
FabienForestier opened this issue Jan 30, 2023 · 3 comments
Closed

Missing function declaration in SubKey type #1587

FabienForestier opened this issue Jan 30, 2023 · 3 comments
Labels
TypeScript

Comments

@FabienForestier
Copy link
Contributor

The SubKey class has a getExpirationTime (

openpgpjs/src/key/subkey.js

Line 110 in 50ea1ac

async getExpirationTime(date = new Date(), config = defaultConfig) {
) but the type definition of a SubKey in openpgp.d.ts does not declare this function.

Am I missing something or should the method be declared in the typings ?
@larabr
Copy link
Collaborator

larabr commented Jan 30, 2023

Typings are not complete, feel free to open a PR :)

@FabienForestier
Copy link
Contributor Author

Yup, here is the pull request: #1588

@larabr
Copy link
Collaborator

larabr commented Feb 17, 2023

Fixed

@larabr larabr closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@larabr @FabienForestier